Opened 11 years ago

Closed 8 years ago

Last modified 4 years ago

#310 closed task (fixed)

Unify prototypes of WKTReader and WKBReader constructor

Reported by: mloskot Owned by: strk
Priority: major Milestone: 3.4.0
Component: Core Version: master
Severity: Annoyance Keywords: history
Cc:

Description

Constructor of both WKTReader and WKBReader accept GeometryFactory?, however both do it in different way:

This is inconsistent and requires extra work on client side. For example, if one wants to write simple function or class template that can be specialised by any of the two reader types it becomes a challenge.

I would suggest to change ctor of WKTReader to accept reference instead of pointer.

Change History (8)

comment:1 Changed 11 years ago by strk

Milestone: 3.3.0

+1

Btw, wouldn't you call these "troubles" ? :)

comment:2 Changed 10 years ago by strk

Milestone: 3.3.0

comment:3 Changed 10 years ago by strk

Milestone: GEOS Future

comment:4 Changed 8 years ago by strk

Milestone: GEOS Future3.4.0
Resolution: fixed
Status: newclosed
Type: defecttask

Done in r3770

comment:5 Changed 7 years ago by robe

Keywords: history added

comment:6 Changed 4 years ago by Sandro Santilli <strk@…>

In ddab738/git:

Deprecate WKTReader constructor taking GeometryFactory? by pointer

Add constructor taking it by reference, for consistency with WKBReader
Closes #310

git-svn-id: http://svn.osgeo.org/geos/trunk@3770 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:7 Changed 4 years ago by Sandro Santilli <strk@…>

In ddab738/git:

Deprecate WKTReader constructor taking GeometryFactory? by pointer

Add constructor taking it by reference, for consistency with WKBReader
Closes #310

git-svn-id: http://svn.osgeo.org/geos/trunk@3770 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:8 Changed 4 years ago by Sandro Santilli <strk@…>

In ddab738/git:

Deprecate WKTReader constructor taking GeometryFactory? by pointer

Add constructor taking it by reference, for consistency with WKBReader
Closes #310

git-svn-id: http://svn.osgeo.org/geos/trunk@3770 5242fede-7e19-0410-aef8-94bd7d2200fb

Note: See TracTickets for help on using tickets.