geos_c.h should always include stddef.h

[slinkp]

geos_c.h contains these lines:

#ifndef __cplusplus
# include <stddef.h> /* for size_t definition */
#endif

I don't know squat about C++, but I'm told by a coworker that the conditional is wrong. It usually happens to work because we have probably already included stddef.h from elsewhere. It should really just be:

# include <stddef.h> /* for size_t definition */

We discovered this while trying to use the h2xml.py script from ctypeslib on geos_c.h... that script in turn uses gccxml. After making the above change, it works.

[mloskot]

The header is supposed to be C and C++ compatible header file, so including <stddef.h> is prerfectly correct, but including <cstddef> would be not.

Does the It should really just be: #include <stddef.h> mean that you have fixed it this way and you have built geos with success? Could you give more details about what platform/compiler you use?

[slinkp]

yes, we built successfully with the proposed change on a gentoo linux box. I no longer have that box though, so I don't know what version of gcc / g++ was on it.

[strk]

Sounds sane to always include. Committed to r2492.

[mloskot]

strk,

What's sane in it? Does geos_c.h use size_t? It does. So, where definition of this type is supposed to come from?

[strk]

... including always stddef.h is, to get that definition.

[mloskot]

First, you objected inclusion of <stddef.h>, then you confirmed it's necessary. Confusing, isn't it?

[strk]

could be a translation problem, I said "Sounds sane to always include".

[mloskot]

It is, indeed. I shouldn't read & reply it hurry. Sorry my fault.