Crash on invalid GeoJSON input (GEOS compiled in Debug mode)

[caspervdw]

I have been wrapping the new GeoJSON reader and writer in pygeos and encountered a few issues.

One issue is that GEOS crashes (aborts) on invalid geojson input ‘{“no”: “GeoJSON”}’. It seems that all places where a field is expected by the reader (e.g. “type”) the exception handling is not OK.

[caspervdw]

This issue is not reproducible on a CI runner (see ​https://github.com/pygeos/pygeos/pull/413)

I will investigate what is going wrong on my local build.

[caspervdw]

So the crash only occurs when GEOS is built with "-DCMAKE_BUILD_TYPE=Debug".

When using -DCMAKE_BUILD_TYPE=Release, the issue goes away.

[rouault]

Fix in ​https://github.com/libgeos/geos/pull/498

[Even Rouault <even.rouault@…>]

In c652f5b/git:

GeoJSON reader: fix crashes (in debug mode) on invalid GeoJSON

json::operator[] is advertised as having undefined behavior when the
request member doesn't exist or the json item is not an object.
json::at() is similar but emits a C++ exception on those situations.

Fixes #1138

[Paul Ramsey <pramsey@…>]

In 9846ac3/git:

GeoJSON reader: fix crashes (in debug mode) on invalid GeoJSON

json::operator[] is advertised as having undefined behavior when the
request member doesn't exist or the json item is not an object.
json::at() is similar but emits a C++ exception on those situations.

Fixes #1138

[caspervdw]

Thanks for the fix! I actually have triggered this issue now also with a Release build, on OSX.