Opened 7 years ago

Closed 7 years ago

#6906 closed defect (fixed)

ogr_xplane_geo_utils needs documentation and to be moved

Reported by: Kurt Schwehr Owned by: warmerdam
Priority: low Milestone:
Component: default Version: unspecified
Severity: minor Keywords:
Cc:

Description

What exactly are these functions doing? The reader currently has to infer from the math what distance and heading algorithm is being used and what the return is. The same for assumptions and errors. And it seems awkward that these are in xplane when used elsewhere... 

find . -type f | egrep -v 'xplane|[.](a|o|so|lo|dylib)$' | xargs grep OGRXPlane | cut -d\( -f1 | sort -u
./ogr/gml2ogrgeometry.cpp:                                        OGRXPlane_Distance
./ogr/gml2ogrgeometry.cpp:                    OGRXPlane_ExtendPosition
./ogr/gml2ogrgeometry.cpp:                OGRXPlane_ExtendPosition
./ogr/ogrsf_frmts/elastic/ogrelasticlayer.cpp:                            OGRXPlane_ExtendPosition
./ogr/ogrsf_frmts/generic/ogrregisterall.cpp:    RegisterOGRXPlane
./ogr/ogrsf_frmts/ogrsf_frmts.h:void CPL_DLL RegisterOGRXPlane
./ogr/ogrsf_frmts/openair/ogropenairlayer.cpp:                    OGRXPlane_ExtendPosition
./ogr/ogrsf_frmts/openair/ogropenairlayer.cpp:                OGRXPlane_ExtendPosition
./ogr/ogrsf_frmts/openair/ogropenairlayer.cpp:                const double dfEndDistance = OGRXPlane_Distance
./ogr/ogrsf_frmts/openair/ogropenairlayer.cpp:                const double dfStartAngle = OGRXPlane_Track
./ogr/ogrsf_frmts/openair/ogropenairlayer.cpp:                const double dfStartDistance = OGRXPlane_Distance
./ogr/ogrsf_frmts/openair/ogropenairlayer.cpp:                double dfEndAngle = OGRXPlane_Track
./ogr/ogrsf_frmts/sua/ogrsualayer.cpp:                OGRXPlane_Distance
./ogr/ogrsf_frmts/sua/ogrsualayer.cpp:                OGRXPlane_ExtendPosition
./ogr/ogrsf_frmts/sua/ogrsualayer.cpp:                OGRXPlane_Track
./ogr/ogrsf_frmts/sua/ogrsualayer.cpp:            OGRXPlane_ExtendPosition

Change History (1)

comment:1 by Even Rouault, 7 years ago

Resolution: → fixed
Status: new → closed

In 38736:

Move ogr_xplane_geo_utils code in OGR code and add a bit of doc (fixes #6906)

Note: See TracTickets for help on using tickets.