Opened 7 years ago

Closed 6 years ago

#6709 closed task (fixed)

What is the ESRI_BUILD flag?

Reported by: Kurt Schwehr Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: unspecified
Severity: normal Keywords:
Cc:

Description

I don't see any documentation or build setups for enabling ESRI_BUILD. Is it somewhere I am missing? Is this code only used by the company? And why? Should some or all of this code get enabled for all? Or is this something old that we could remove?

find . -type f | grep -v svn | xargs grep ESRI_BUILD | grep -v endif | sort -u
./autotest/gcore/tiff_read.py:    if build_info.find('ESRI_BUILD=YES') == -1:
./gdal/NEWS: * 1-bit null blocks to default to 1 in ESRI_BUILDs
./gdal/NEWS: * Include service url in GetFileList if ESRI_BUILD defined
./gdal/frmts/gtiff/geotiff.cpp:#ifdef ESRI_BUILD
./gdal/frmts/gtiff/gt_citation.cpp:#if !defined(ESRI_BUILD)
./gdal/frmts/hfa/hfaband.cpp:#ifdef ESRI_BUILD
./gdal/frmts/nitf/nitf_gcprpc.cpp:#ifdef ESRI_BUILD
./gdal/frmts/nitf/nitf_gcprpc.cpp:/* Unused in normal builds. Caller code in nitfdataset.cpp is protected by #ifdef ESRI_BUILD */
./gdal/frmts/nitf/nitfdataset.cpp:#ifdef ESRI_BUILD
./gdal/frmts/nitf/nitfdataset.h:#ifdef ESRI_BUILD
./gdal/frmts/nitf/nitfdataset.h:/* Unused in normal builds. Caller code in nitfdataset.cpp is protected by #ifdef ESRI_BUILD */
./gdal/frmts/wcs/wcsdataset.cpp:#ifdef ESRI_BUILD
./gdal/gcore/gdal_misc.cpp:        osBuildInfo += "ESRI_BUILD=YES\n";
./gdal/gcore/gdal_misc.cpp:#ifdef ESRI_BUILD

I see changes like:

r21888 r22701 r22840

Change History (4)

comment:1 by Even Rouault, 7 years ago

The -DESRI_BUILD needs to be manually defined. This is code coming from merge attempts of the ESRI fork (https://trac.osgeo.org/gdal/browser/sandbox/warmerdam/1.8-esri) and that isn't enabled because we aren't unusure if it's general purpose or not. Recently I looked at some of this code in the NITF driver and some of it could be of interest, so I'd let it like it is (even if it doesn't compile due to changes between)

comment:2 by Kurt Schwehr, 7 years ago

Looking at r21789, the actual branch, I don't see any reference to why the branch was made. e.g. r21925 adds code, but I don't see any added use of it.

Was this a branch to read ESRI versions of files, be used by Arc/GIS or some other ESRI tool, or ?

comment:3 by Even Rouault, 7 years ago

I think this is the GDAL code used in one of the ArcGIS versions. Frank would better know. Regarding r21925 it looks like this wasn't merged back to trunk, probably for the reason you point (not being actually used)

comment:4 by Even Rouault, 6 years ago

Resolution: fixed
Status: newclosed

Question answered. Closing

Note: See TracTickets for help on using tickets.