API: Can we drop the ifdef for VSIL_STRICT_ENFORCE and just always have it be the struct?

[Kurt Schwehr]

What drawbacks, if any are there to just going with what is within the VSIL_STRICT_ENFORCE?

cpl_vsi.h

@@ -124 +124 @@
 typedef GUIntBig vsi_l_offset;
 #define VSI_L_OFFSET_MAX GUINTBIG_MAX
 
-/* Make VSIL_STRICT_ENFORCE active in DEBUG builds */
-#ifdef DEBUG
-#define VSIL_STRICT_ENFORCE
-#endif
-
-#ifdef VSIL_STRICT_ENFORCE
 typedef struct _VSILFILE VSILFILE;
-#else
-typedef FILE VSILFILE;
-#endif
 
 VSILFILE CPL_DLL *  VSIFOpenL( const char *, const char * ) CPL_WARN_UNUSED_RESULT;
 VSILFILE CPL_DLL *  VSIFOpenExL( const char *, const char *, int ) CPL_WARN_UNUSED_RESULT;

[Even Rouault]

It has 2 impacts : it slightly changes the C++ ABI (OK), and could potentially cause compilation issues for external code (since GDAL code must be OK now) that would use FILE* when using VSIFOpenL(). This should be documented in the MIGRATION_GUIDE.

[Even Rouault]

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.