Opened 8 years ago

Closed 8 years ago

#6263 closed defect (fixed)

ogrbnadatasource.cpp OGRBNADataSource::TestCapability() possibly wrong

Reported by: Kurt Schwehr Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

Was returning FALSE for ODsCDeleteLayer intensional? If FALSE was intended, then we should remove the unused part of this #if 0 else. Was there a reason to specifically call out the false for delete layer in r11853?

  • ogrbnadatasource.cpp

     
    8382{
    8483    if( EQUAL(pszCap,ODsCCreateLayer) )
    8584        return TRUE;
     85#if 0
     86    // TODO: Is this really false for both?
    8687    else if( EQUAL(pszCap,ODsCDeleteLayer) )
    8788        return FALSE;
    8889    else
    8990        return FALSE;
     91#else
     92    return FALSE;
     93#endif
    9094}

​https://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/bna/ogrbnadatasource.cpp?rev=11853

Change History (1)

comment:1 by Even Rouault, 8 years ago

Resolution: → fixed
Status: new → closed

trunk r32139 "BNA: remove dead code (#6263)"

Note: See TracTickets for help on using tickets.