Opened 8 years ago

Closed 5 years ago

#6167 closed task (wontfix)

Convert debugging printf's to CPLDebug

Reported by: Kurt Schwehr Owned by: Kurt Schwehr
Priority: normal Milestone: closed_because_of_github_migration
Component: default Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

e.g. source:trunk/gdal/ogr/ogrgeometryfactory.cpp#L4026​ 

#ifdef VERBOSE_DEBUG_CURVEFROMLINESTRING
                printf("initial_error=%f\n", dfBestRError);
#endif

Should probably be 

#ifdef DEBUG_VERBOSE
                CPLDebug("CURVEFROMLINESTRING", "initial_error=%f\n", dfBestRError);
#endif

A good fraction of these might be convertible. 

find port frmts ogr alg -name \*.cpp | egrep -v '/lib|dump|degrib18'| xargs grep printf  | egrep -v 'fprintf|sprintf|snprintf' | wc -l
491

It would also be nice to not have CPLDebug statements commented out any more so that we can make sure they still compile. Can we put them all behind DEBUG_VERBOSE? Then I can do my typical incremental building with and with out DEBUG_VERBOSE like so:

Error: Failed to load processor bash
No macro or processor named 'bash' found

e.g. for this type of stuff:

Error: Failed to load processor bash
No macro or processor named 'bash' found

Change History (1)

comment:1 by Even Rouault, 5 years ago

Milestone: → closed_because_of_github_migration
Resolution: → wontfix
Status: new → closed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.