Disallow copy and assignment in OGRFeatureDefn

[Kurt Schwehr]

This is a change I'd like to add to make sure that sneaky copy or assignment usages do not creep in on OGRFeatureDefn where reference counting is happening. Any reason not to add the pre-C++11 version of restriction?

ogr/ogr_feature.h

@@ -252 +252 @@
 
     static OGRFeatureDefn  *CreateFeatureDefn( const char *pszName = NULL );
     static void         DestroyFeatureDefn( OGRFeatureDefn * );
+
+  private:
+    // Disable copy and assignment to prevent reference counting problems.
+    OGRFeatureDefn( const OGRFeatureDefn &that );  // No implementation.
+    OGRFeatureDefn &operator=( const OGRFeatureDefn& );  // No implementation.
 };
 
 /************************************************************************/

Someday when C++11 is allowed, this would be

OGRFeatureDefn( const OGRFeatureDefn &that ) = delete;
OGRFeatureDefn &operator=( const OGRFeatureDefn& ) = delete;

Which could be behind an if:

#if __cplusplus >= 201103L
    OGRFeatureDefn( const OGRFeatureDefn &that ) = delete;
    OGRFeatureDefn &operator=( const OGRFeatureDefn & ) = delete;
#else
  private:
    // Disable copy and assignment to prevent reference counting problems.
    OGRFeatureDefn( const OGRFeatureDefn &that );  // No implementation.
    OGRFeatureDefn &operator=( const OGRFeatureDefn & );  // No implementation.
#endif

​http://stackoverflow.com/questions/6077143/disable-copy-constructor