Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#5800 closed enhancement (fixed)

[PATCH][RFC] Adding support for ROI_PAC image creation

Reported by: mazhe Owned by: warmerdam
Priority: normal Milestone: 2.0.0
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: ROI_PAC driver write
Cc: antonio

Description

Hi and happy new year,

I'd like to continue and improve my previous contribution (thanks again for improving and including it) by adding raster creation to the ROI_PAC driver.

I'm including a preliminary patch for the gdal source tree and another for the autotest, but there is a bug for now as output files do not have their ROI_PAC domain metadata. I was kind of hoping for pointers as to what is wrong.

I've taken the Envi driver as reference many times and do not see what could be wrong...

Thanks again for your work and time,

Attachments (3)

test_roipac_write.diff (883 bytes) - added by mazhe 7 years ago.
Test file creation/copy, and VSIL operations
driver_roipac_write.2.diff (24.6 KB) - added by mazhe 7 years ago.
driver_roipac_write.diff (24.6 KB) - added by mazhe 7 years ago.
Implements Create() and other necessary parts for file creation

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by antonio

Cc: antonio added

Changed 7 years ago by mazhe

Attachment: test_roipac_write.diff added

Test file creation/copy, and VSIL operations

comment:2 Changed 7 years ago by mazhe

Driver was updated with georeferencing updated from dataset transform, not metadata from the ROI_PAC domain (those metadata are now filtered to prevent confusion).

Changed 7 years ago by mazhe

Attachment: driver_roipac_write.2.diff added

Changed 7 years ago by mazhe

Attachment: driver_roipac_write.diff added

Implements Create() and other necessary parts for file creation

comment:3 Changed 7 years ago by Even Rouault

Milestone: 2.0
Resolution: fixed
Status: newclosed

Committed with a fix for a wrong use of importFromWkt (whose strange interface modifies the pased pointer), and replace it with SetFromUserInput?() which is easier.

trunk r283707 "ROIPAC: add write support (patch by Matthieu Violat, #5800)"

comment:4 Changed 6 years ago by Even Rouault

Milestone: 2.02.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.