Unused templates in gdalwarpkernel

[Kurt Schwehr]

Is there a case where the these two templates are actually used?

(cd alg; /Applications/Xcode.app/Contents/Developer/usr/bin/make)
/bin/sh /Users/schwehr/src/gdal/gdal/libtool --mode=compile --tag=CXX g++ -Wall -Wextra -Werror  -I/Users/schwehr/src/gdal/gdal/port -I/Users/schwehr/src/gdal/gdal/gcore -I/Users/schwehr/src/gdal/gdal/alg -I/Users/schwehr/src/gdal/gdal/ogr -I/Users/schwehr/src/gdal/gdal/ogr/ogrsf_frmts -g -O2  -Wall  -DHAVE_SSE_AT_COMPILE_TIME -DHAVE_AVX_AT_COMPILE_TIME -DOGR_ENABLED -I/sw/include -I/Users/schwehr/src/gdal/gdal/port -I/sw/include -I/sw -I/sw/include  -DGDAL_COMPILATION  -c -o gdalwarpkernel.lo gdalwarpkernel.cpp
libtool: compile:  g++ -Wall -Wextra -Werror -I/Users/schwehr/src/gdal/gdal/port -I/Users/schwehr/src/gdal/gdal/gcore -I/Users/schwehr/src/gdal/gdal/alg -I/Users/schwehr/src/gdal/gdal/ogr -I/Users/schwehr/src/gdal/gdal/ogr/ogrsf_frmts -g -O2 -Wall -DHAVE_SSE_AT_COMPILE_TIME -DHAVE_AVX_AT_COMPILE_TIME -DOGR_ENABLED -I/sw/include -I/Users/schwehr/src/gdal/gdal/port -I/sw/include -I/sw -I/sw/include -DGDAL_COMPILATION -c gdalwarpkernel.cpp  -fno-common -DPIC -o .libs/gdalwarpkernel.o
gdalwarpkernel.cpp:1094:19: error: unused function 'GWKRoundValueT' [-Werror,-Wunused-function]
template<> double GWKRoundValueT<double>(double dfValue)
                  ^
gdalwarpkernel.cpp:1114:19: error: unused function 'GWKClampValueT' [-Werror,-Wunused-function]
template<> double GWKClampValueT<double>(double dfValue)
                  ^
2 errors generated.

Proposed change:

alg/gdalwarpkernel.cpp

@@ -1091 +1091 @@
                                                  (T)(dfValue + 0.5);
 }
 
-template<> double GWKRoundValueT<double>(double dfValue)
-{
-    return dfValue;
-}
-
 /************************************************************************/
 /*                            GWKClampValueT()                          */
 /************************************************************************/
@@ -1111 +1106 @@
         return GWKRoundValueT<T>(dfValue);
 }
 
-template<> double GWKClampValueT<double>(double dfValue)
-{
-    return dfValue;
-}
-
 /************************************************************************/
 /*                         GWKSetPixelValueRealT()                      */
 /************************************************************************/

[Even Rouault]

Not currently used, but could potentially be if other templates would specialize double. You can disable them with #ifdef notused.

[Kurt Schwehr]

r28226 in trunk