Change History (4)
comment:1 by , 11 years ago
follow-up: 4 comment:3 by , 11 years ago
I find the following line particularly suspicious :
bUseGeometryColumns = !CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "NO"));
I guess it only works when MSSQLSPATIAL_USE_GEOMETRY_COLUMNS isn't set. But if someone sets MSSQLSPATIAL_USE_GEOMETRY_COLUMNS to NO, bUseGeometryColumns will be TRUE.
So I'd suggest removing the double negation : bUseGeometryColumns = CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "YES"));
comment:4 by , 11 years ago
Replying to rouault:
I find the following line particularly suspicious :
bUseGeometryColumns = !CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "NO"));
I guess it only works when MSSQLSPATIAL_USE_GEOMETRY_COLUMNS isn't set. But if someone sets MSSQLSPATIAL_USE_GEOMETRY_COLUMNS to NO, bUseGeometryColumns will be TRUE.
So I'd suggest removing the double negation : bUseGeometryColumns = CSLTestBoolean(CPLGetConfigOption("MSSQLSPATIAL_USE_GEOMETRY_COLUMNS", "YES"));
You might be true. Changed this way
Also: