Opened 7 years ago

Closed 7 years ago

#4966 closed enhancement (fixed)

OCI <=> NAS interoperability patch

Reported by: jef Owned by: ilucena
Priority: normal Milestone:
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords:
Cc:

Description (last modified by jef)

Please consider to merge pull request #9

It fixes following issues raised when trying to import NAS data to Oracle:

  • pre-existing tables with laundered names are not recognized (NAS contains some tables with names longer than 30 characters)
  • the fid counting is not continued when data is appended (NAS data sets are split into multiple files)
  • identifiers are not quoted, so some identifiers cause problems (eg. the NAS driver uses a table called "delete", which is a token that needs to be quoted).

Attachments (2)

0001-OCI-driver.patch (14.9 KB) - added by jef 7 years ago.
pull request as patch
0001-OCI-driver.2.patch (12.7 KB) - added by jef 7 years ago.
same patch from svn

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by jef

See also pull request #7 which was applied without the OCI part.

comment:2 Changed 7 years ago by jef

Description: modified (diff)

comment:3 Changed 7 years ago by jef

Description: modified (diff)

Changed 7 years ago by jef

Attachment: 0001-OCI-driver.patch added

pull request as patch

comment:4 Changed 7 years ago by ilucena

Could please generate that patch again from the GDAL main folder or from ogr? I am having a hard time applying your patch with TortoiseSVN on Windows 7 and Linux and OS X machines are not available right now. I tried to editing it removing comments and changing paths but that did not work. Thanks.

Changed 7 years ago by jef

Attachment: 0001-OCI-driver.2.patch added

same patch from svn

comment:5 Changed 7 years ago by ilucena

Resolution: fixed
Status: newclosed

Patch applied at revision: r25656

Note: See TracTickets for help on using tickets.