Opened 10 years ago

Closed 10 years ago

#4791 closed defect (fixed)

RPFTOCProxyRasterDataSet::SanityCheckOK() too restrictive

Reported by: Even Rouault Owned by: Even Rouault
Priority: normal Milestone: 1.9.2
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: rpftoc cib
Cc:

Description

RPFTOCProxyRasterDataSet::SanityCheckOK() has too strict checks, namely WARN_CHECK_DS(fabs(adfGeoTransform[GEOTRSFRM_TOPLEFT_X] - nwLong) < 1e-10) which can fail with a CIB 5Meter in Zone 1 where adfGeoTransform[GEOTRSFRM_TOPLEFT_X] = 32.036011080332401 and nwLong = 32.036035630999997, which equals -0.000024550667596 and is then greater than 1e-10.

But as 1 degree ~= 110 km, 0.000024550667596 * 110000 = 2.7 m, that is to say half a pixel error, which is OK.

I'll relax the test to check that the error is not more than one pixel, and I'll just make it a warning instead of an error for that test. A few other structural tests must still be error (could potentially lead to crash, unless further analysis shows the contrary), but georeferencing does not.

Change History (1)

comment:1 by Even Rouault, 10 years ago

Resolution: fixed
Status: newclosed

Fixed in trunk (r24857) and branches/1.9 (r24858)

Note: See TracTickets for help on using tickets.