Opened 12 years ago

Last modified 10 years ago

#4331 closed enhancement

Adding SXF file format driver — at Version 2

Reported by: bidandou Owned by: bidandou@…
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: SXF
Cc: warmerdam, dron, rutsky

Description (last modified by bidandou)

the goal of the work is to add a GDAL driver supporting the SXF (Storage and eXchange Format). This file format is largely used in the eastern europe, and is primarly produced by a GIS software Called Panorama GIS MAP developped by the Russian KB Panorama Entreprise

informationons on : http://www.gisinfo.net/ Specification on (in Russian Language) : http://gistoolkit.ru/download/doc/sxf4bin.pdf

Change History (5)

by bidandou, 12 years ago

Attachment: drv_sxf.html added

by bidandou, 12 years ago

Attachment: makefile.vc added

by bidandou, 12 years ago

Attachment: GNUmakefile added

comment:1 by Even Rouault, 12 years ago

Cc: warmerdam dron added

I have several high level remarks and questions :

  • For significant contributions like a new driver, we'd ask that you publicly declare in an email to gdal-dev mailing list that your contribution matches the requirements of the "Legal" paragraph of http://trac.osgeo.org/gdal/wiki/rfc3_commiters
  • Do you have rights to publish sxf.h under the X/MIT licence ? There's no copyright notice in the file, and I've got under the impression that it might come from another project. Please correct me if I'm wrong.
  • Is there a public specification of the format somewhere ?
  • You should put your full name in the copyright notice of the files, not the osgeo id.
  • The first thing to fix is the indendation of the files. Please don't use tab characters, but use instead 4 spaces for each indentation level. See http://trac.osgeo.org/gdal/wiki/rfc8_devguide
  • Remove dead code that is commented
  • Remove printf statements. You can use CPLDebug infrastructure if needed
  • Do you have links to SXF datasets that could be used to test your contribution ? Ideally we would need a freely redistribuable and small datasource so that a regression test can be written.
  • With which OS did you test your driver : Linux, Windows ?
  • Your code will only work on little-endian processors. Not a critical issue for now however...

Note : to avoid the proliferation of files when you update new revisions of your work, you can overwrite existing files attached to the ticket by checking the "Replace existing attachment of the same name" box.

CC'ing Andrey Kiselev who has contributed stuff in GDAL for Panorama SRS

Merci de votre contribution !

comment:2 by bidandou, 12 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.