#4163 closed enhancement (fixed)
FGDB options for controlling precision grid
Reported by: | pramsey | Owned by: | Even Rouault |
---|---|---|---|
Priority: | high | Milestone: | 1.9.0 |
Component: | default | Version: | svn-trunk |
Severity: | normal | Keywords: | |
Cc: |
Description
The FGDB file creates features on a precision grid, so users should be able to modify the default grid when creating new layers. Attached patch allows this.
Attachments (2)
Change History (10)
by , 13 years ago
Attachment: | fgdb-precision.patch added |
---|
comment:1 by , 13 years ago
comment:2 by , 13 years ago
I'm on 32-bit and don't recall that level of death and destruction... I did up the default resolution a lot so that could be the source... I'll see if I can cause it to happen here.
comment:3 by , 13 years ago
Correction, I'm experiencing the same death and destruction in the same place... the FGDB code just doesn't like my default precision parameters. Will have to juggle them around a bit.
comment:5 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
r22755 /trunk/gdal/ogr/ogrsf_frmts/filegdb/ (FGdbDatasource.cpp FGdbLayer.cpp drv_filegdb.html ogr_fgdb.h): FileGDB: add options for controlling precision grid (patch fgdb-precision-2.patch by Paul Ramsey, #4163)
r22756 /trunk/autotest/ogr/ogr_fgdb.py: More testing of FGDB driver
r22757 /trunk/gdal/ogr/ogrsf_frmts/filegdb/ (6 files): FileGDB: stylistic change to conform to usual GDAL coding habits : 4 space indentation level
comment:6 by , 13 years ago
Could you let me know before you re-format things on me, you've caught me with a bunch of changes that are now in conflict.
comment:8 by , 13 years ago
ah sorry. When I refer to 4 space indentation level, this is for the rest of the code base. This driver was an exception.
Paul, I applied the patch in my dev tree, and I get really nasty crashes when running the ogr_fgdb.py test (or when doing ogr2ogr -f filegdb some.gdb some.shp). This is with Linux 64bit.
Here are the Valgrind traces with ogr_fgdb.py :
And below with :