Opened 9 years ago

Closed 7 months ago

#3963 closed enhancement (wontfix)

Georaster makefile.vc always links with the builtin jpeg library

Reported by: ftrastour Owned by: warmerdam
Priority: normal Milestone: closed_because_of_github_migration
Component: ConfigBuild Version: 1.8.0
Severity: normal Keywords: build system
Cc: ilucena

Description

The windows makefile "makefile.vc" of the georaster driver links with the builtin jpeg library instead of using the JPEG_LIB variable which can point to the builtin library or to an external one depending on user settings.

Attachments (1)

makefile.vc (1.1 KB) - added by ftrastour 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by ftrastour

Attachment: makefile.vc added

comment:1 Changed 9 years ago by Even Rouault

Cc: ilucena added
Component: defaultConfigBuild
Keywords: build added; buid removed

comment:2 Changed 9 years ago by ilucena

That makefile does have option to use internal or external JPEG library:

13    !IFDEF JPEG_SUPPORTED
14    !IFDEF JPEG_EXTERNAL_LIB
15    JPEG_FLAGS =    -I$(JPEGDIR) -DJPEG_SUPPORTED
16    !ELSE
17    JPEG_FLAGS =    -I..\jpeg\libjpeg -DJPEG_SUPPORTED
18    !ENDIF
19    !ENDIF

Would that be the case the the JPEG driver has been changed over time now requiring one more flag, the JPEG_LINKER_FLAG?

13	!IFDEF JPEG_SUPPORTED
14	!IFDEF JPEG_EXTERNAL_LIB
15	JPEG_FLAGS = -I$(JPEGDIR) -DJPEG_SUPPORTED
16	JPEG_LINKER_FLAGS = $(JPEG_LIB)
17	!ELSE
18	JPEG_FLAGS = -I..\jpeg\libjpeg -DJPEG_SUPPORTED
19	JPEG_LINKER_FLAGS = ..\jpeg\libjpeg\libjpeg.lib
20	!ENDIF
21	!ENDIF

Wouldn't be better to have it on nmake.opt instead of breaking other drivers build?

185    #if using an external jpeg library uncomment the follwing lines
186    #JPEG_EXTERNAL_LIB = 1
187    #JPEGDIR = c:/projects/jpeg-6b
188    #JPEG_LIB = $(JPEGDIR)/libjpeg.lib
       #JPEG_LINKER_FLAG = 

comment:3 Changed 5 years ago by Jukka Rahkonen

Have these suggestion lead to any action?

comment:4 Changed 7 months ago by Even Rouault

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: newclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub?. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.