Opened 12 years ago

Closed 12 years ago

#3953 closed defect (fixed)

Memory leak in BAG dataset

Reported by: rprinceley Owned by: warmerdam
Priority: normal Milestone: 1.8.1
Component: GDAL_Raster Version: 1.8.0
Severity: normal Keywords: hdf5 bag
Cc: gaopeng

Description

There appears to be one or more cases of missing H5?close calls in the BAG implementation. This is causing memory leaks.

Also, we had to change nAttrSize in HDF5AttrIterate() from:

nAttrSize = H5Tget_size( hAttrTypeID );

to:

nAttrSize = H5Aget_storage_size( hAttrID );

Attached is a patch that adds these calls. We are still testing these, please review and include if appropriate.

Attachments (1)

hdf5.patch (3.2 KB ) - added by rprinceley 12 years ago.

Download all attachments as: .zip

Change History (2)

by rprinceley, 12 years ago

Attachment: hdf5.patch added

comment:1 by warmerdam, 12 years ago

Component: defaultGDAL_Raster
Keywords: hdf5 bag added
Milestone: 1.8.1
Resolution: fixed
Status: newclosed

I have reviewed and tested the patch and it seems good. Applied in trunk (r21650) and 1.8 branch (r21651).

Thanks!

Note: See TracTickets for help on using tickets.