Enhancements to OGR OCI driver to support creation of non-spatial tables

[PeterHalls]

Some GML datasets comprise a mixture of spatial and non-spatial dataset information. Hitherto, the OCI driver has always created output tables including a geometry column. This patch avoids the creation of a geometry column for a new feature layer when the geometry type is wkbNone; for all other values of geometry type the geometry column is created as before. This change will also enable programmers to use GDAL alone where both spatial and non-spatial tables must be manipulated, avoiding the need for multiple api's.

The changes affect ogrocidatasource.cpp (ogrocidatasource.changes) and ogrocitablelayer.cpp (ogrocitablelayer.changes). The diff files and modified sources are submitted.

[PeterHalls]

diff output between supplied and modified sources

[PeterHalls]

modified source of ogrocidatasource.cpp

[PeterHalls]

diff output between supplied and modified sources

[PeterHalls]

modified source of ogrocitablelayer.cpp

[warmerdam]

Ivan,

Is this something you have funded time you can apply to it? Either via the maintainer contract or other?

[ilucena]

I can take a look at that.

[ilucena]

Frank,

I applied the changes to the current on trunk. It looks consistent but it seems like Peter started his changes on 1.7 or some older version of the code so I needed to accommodate things with the latest fix/improvements.

It seems to be working fine now but note that since the newly created table does not have a geometry, it doesn't shows up on a ogrinfo query, example:

% ogr2ogr -f "OCI" oci:scott/tiger@orcl sample.csv
% ogrinfo oci:scott/tiger@orcl
INFO: Open of `oci:scott/tiger@orcl'
      using driver `OCI' successful.
1: ABC
2: USGS24KGRID
3: TEST

r20120