Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#3634 closed enhancement (fixed)

[PATCH] RPC_DEM functionality in GDALRPCTransform — at Version 6

Reported by: bishop Owned by: Even Rouault
Priority: normal Milestone: 1.10.0
Component: GDAL_Raster Version: svn-trunk
Severity: normal Keywords: RPC DEM GDALCreateRPCTransformer GDAL Warp GDALRPCTransform
Cc:

Description (last modified by bishop)

Fixed in r24094

Change History (8)

by bishop, 14 years ago

Attachment: gdal_rpc_demfile.patch added

add support for DEM files

comment:1 by bishop, 14 years ago

Summary: [patch] RPC_DEM functionality in GDALRPCTransform[PATCH] RPC_DEM functionality in GDALRPCTransform

comment:2 by Even Rouault, 14 years ago

Milestone: 1.8.0
Owner: changed from warmerdam to Even Rouault

I've made a few changes and commited them in r19864 and r19866. Test added in r19865.

The changes are :

  • lazy opening of the DEM file the first time we need it and close it only when the transform is destroyed (address the point in your comment)
  • caching of the inverse geotransform et coordinate transform
  • replace OGR errors -> CPL errors
  • test that dX, dY is in the extent of the dataset
  • replace GDT_Int16 by GDT_Int32 as we use array of int and not array of short
  • several fixes in the bDstToSrc == FALSE case that wasn't probably much tested (padfX[i] used instead of padfY[i] at line 736, poCT->Transform() was wrongly tested against OGRERR_xxx instead of TRUE/FALSE)

Please test and report if it still works for you.

comment:3 by bishop, 14 years ago

Great work! I have tested it. The result is more accurate (in case of output image size) and the speed is march faster (about 5 times). The test data with RPC was taken from DigitalGlobe samples (http://www.digitalglobe.com/index.php/70/Product+Samples) - QuickBird: Ortho Ready Standard Satellite Imagery And DEM file was taken from here http://www.gdem.aster.ersdac.or.jp/

comment:4 by Even Rouault, 14 years ago

Resolution: fixed
Status: newclosed

comment:5 by bishop, 14 years ago

Resolution: fixed
Status: closedreopened

I added cubic interpolation of elevation and config option (GDAL_RPCDEMINTERPOLATION) to choose between BILINEAR and CUBIC

by bishop, 14 years ago

dem interpolation patch

comment:6 by bishop, 12 years ago

Description: modified (diff)
Milestone: 1.8.12.0.0
Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.