Opened 14 years ago

Closed 6 years ago

#3475 closed defect (fixed)

[PATCH] mitab_bounds.cpp : add missing initializers and make big array read-only

Reported by: Even Rouault Owned by: Daniel Morissette
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: mitab
Cc:

Description

Attached a patch that removes a substantial number of lines of warnings from the log at ​http://mateusz.loskot.net/tmp/gdal/gcc441-x64-r19099.warnings.

The following members of the array are indeed not explictely initialized : 

    GByte       nAffineFlag;    // 0=No affine param, 1=Affine params   
    GByte       nAffineUnits;
    double      dAffineParamA;  // Affine params
    double      dAffineParamB;
    double      dAffineParamC;
    double      dAffineParamD;
    double      dAffineParamE;
    double      dAffineParamF;

It is also good to mark the array as const to load it in the read-only section of the GDAL shared object.

Attachments (1)

ticket_3475.patch​ (303.9 KB ) - added by Even Rouault 14 years ago.

Download all attachments as: .zip

Change History (2)

by Even Rouault, 14 years ago

Attachment: ticket_3475.patch​ added

comment:1 by Even Rouault, 6 years ago

Resolution: → fixed
Status: new → closed

I believe this issue has been addressed

Note: See TracTickets for help on using tickets.