Opened 15 years ago
Closed 15 years ago
#2851 closed defect (fixed)
Update internal libgeotiff to 1.2.5+
Reported by: | hobu | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | 1.7.0 |
Component: | GDAL_Raster | Version: | svn-trunk |
Severity: | normal | Keywords: | gtiff libgeotiff |
Cc: |
Description
Frank,
I don't know what the standard procedure is for updating an internal library, but I would like to be able to depend on the simple keys geotiff stuff for a GDAL-only linkage for libLAS.
Attached is a patch that just does copy *.h *.c into the frmts/gtiff/libgeotiff directory and updates the GNUMakefile to include geo_simplekeys. I don't know if this is the proper way to update things. If you are ok with it, I can commit my local tree. Otherwise, I'll leave it to you to patch things and upgrade as appropriate.
Thanks,
Howard
Attachments (2)
Change History (5)
by , 15 years ago
Attachment: | libgeotiff.patch added |
---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Howard,
I think geo_config.h and cpl_serv.h should not be updated for GDAL internal libgeotiff. The first one for GDAL just includes cpl_config.h, and the second one cpl_string.h and cpl_csv.h. I've noticed that geo_simpletags.[h|c] are missing in the patch, and makefile.vc hasn't been updated.
I'm attaching an updated version, with a small text file HOWTO-REFRESH.txt, that summarizes the procedure I've followed.
by , 15 years ago
Attachment: | libgeotiff-ERO.patch added |
---|
comment:3 by , 15 years ago
Component: | default → GDAL_Raster |
---|---|
Keywords: | gtiff libgeotiff added |
Resolution: | → fixed |
Status: | new → closed |
The GNUmakefile in the libgeotiff directory includes an "import" target. I have updated it slightly , done an import, and added the simple tags interface as well. The results are committed in trunk (r16401). My testing has been non-existant, so let me know if there are any problems.
eh, that patch isn't going to work: