Opened 15 years ago
Closed 15 years ago
#2831 closed defect (fixed)
[PATCH] PCIDSK : add more checks when reading dataset
| Reported by: | Even Rouault | Owned by: | Even Rouault |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | GDAL_Raster | Version: | unspecified |
| Severity: | normal | Keywords: | PCIDSK |
| Cc: | warmerdam, dron |
Description
I've reviewed a bit PCIDSK reading code and propose the attached patch to add more checks. However I lack (valid) test data to be sure that it doesn't break reading on valid datasets. In particular, there's nothing testing tiledrasterband in autotest.
Attachments (1)
Change History (3)
by , 15 years ago
| Attachment: | pcidsk.patch added |
|---|
comment:1 by , 15 years ago
| Component: | default → GDAL_Raster |
|---|---|
| Keywords: | PCIDSK added |
| Owner: | changed from to |
comment:2 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I have reviewed the patch and applied it in r17688 with few minor modifications. Looks good to me.
Best regards, Andrey
Note:
See TracTickets
for help on using tickets.
Even,
There is PCIDSK test data at http://download.osgeo.org/gdal/data/pcidsk
The changes are frankly too extensive for me to review and test carefully and I'm not prepared to apply them and risk breakage. You may apply them if the improvements in safety are important enough to you.