Opened 15 years ago

Closed 15 years ago

#2600 closed enhancement (fixed)

Update to NTF Loader for OS Strategi and OS Meridian2 Datasets

Reported by: agxs Owned by: warmerdam
Priority: high Milestone: 1.6.0
Component: OGR_SF Version: 1.5.2
Severity: normal Keywords: NTF
Cc:

Description

I have updated the NTF loader to support the latest attributes for the above datasets. In Merdian2 only the point feature type had attribute alterations. Strategi had alterations to point, line and text feature types.

Stragegi has had two attributes removed since this loader was updated(AN and AO) but I left these in so that loading older versions of the dataset would still work properly.

Here are links to the sample datasets to help testing. I decided to link directly to the files instead of including the sample data with this ticket due to potential licensing issues.

Unfortunately they are self extractable zips in .exe format.

http://www.ordnancesurvey.co.uk/oswebsite/products/meridian2/sampledata/meridian2ntf.exe http://www.ordnancesurvey.co.uk/oswebsite/products/strategi/sampledata/stratntf.exe

Attachments (2)

ntfpatch.diff (5.0 KB ) - added by agxs 15 years ago.
ntfpatch2.diff (5.6 KB ) - added by agxs 15 years ago.

Download all attachments as: .zip

Change History (7)

by agxs, 15 years ago

Attachment: ntfpatch.diff added

comment:1 by agxs, 15 years ago

Hi,

I've looked a bit more at the existing attributes in the Meridian2 Point table and noticed that some attributes were being put into the incorrect column and being truncated. I've checked my unmodified version of GDAL 1.5.2 and the same thing occurs so my previous patch hasn't changed that.

I've updated the patch (ntfpatch2.diff) to also fix this issue. This patch contains both the updated to Strategi and Meridian2 NTF formats and fixes the attribute errors in Meridian2 Point.

by agxs, 15 years ago

Attachment: ntfpatch2.diff added

comment:2 by warmerdam, 15 years ago

Keywords: NTF added
Milestone: 1.6.0
Priority: normalhigh
Status: newassigned

comment:3 by warmerdam, 15 years ago

I've built and tested in trunk and the changes look pretty solid. I'm concerned that there seems to be changes to the names of some fields for no apparent reason. It seems to me this may cause problems for some applications expecting old names. What was the rationale for the change?

< DLUA_ID: String (13.0)
< WATER_AREA_ID: String (13.0)
---
> DA_DLUA_ID: String (13.0)
> WATER_AREA: String (13.0)

comment:4 by agxs, 15 years ago

The attribute names have changed in the NTF files since this importer was complete so I changed them to match. Here is an extract from the top of one:

40DA013A13 DLUA ID\DLUA IDENTIFIER\0%

I think they attributes weren't being read properly but I can double check that next week.

comment:5 by warmerdam, 15 years ago

Resolution: fixed
Status: assignedclosed

I have applied the second patch, but reverted to the names DA_DLUA_ID and WATER_AREA for MERIDIAN2_POINT. The suggested new names might be more accurate but I feel this could cause unwarranted problems for folks with existing translation scripts setup.

The changes are in trunk (r15637). I'm hesitant about migrating this into 1.5.x without further validation.

Note: See TracTickets for help on using tickets.