Opened 16 years ago
Closed 16 years ago
#2317 closed defect (fixed)
C++ issue on some archs with GCC 4.3
Reported by: | frankie | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | 1.5.2 |
Component: | OGR_SF | Version: | 1.5.0 |
Severity: | normal | Keywords: | geojson |
Cc: | warmerdam |
Description
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=474415
Please avoid the use of such common used max/min macros. It is much better using some unique names such as OGR_max/OGR_min to avoid name clashes.
Change History (3)
comment:1 by , 16 years ago
Cc: | added |
---|---|
Component: | default → OGR_SF |
Keywords: | geojson added |
Milestone: | → 1.5.2 |
Version: | unspecified → 1.5.0 |
comment:2 by , 16 years ago
This seems fixed in trunk, I backported a patch in 1.5.1-2 on Debian, thanks. See changesets 13700 and 13701.
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
I can confirm that geojson/jsonc/bits.h defines min and max macros like this:
This is a dangerous practice. This needs to be reworked to do something else, likely just use the MIN/MAX defined in cpl_port.h or rename the macros something specific. Matuesz, if you don't have time to deal with this shortly, let me know and I'll have Chris address it.