Opened 13 years ago

Closed 6 years ago

#2084 closed defect (wontfix)

Core depends on drivers (KML/GeoJson)

Reported by: wbaer Owned by: warmerdam
Priority: low Milestone:
Component: WinCE Port Version: 1.5.0 betas/RCs
Severity: normal Keywords: WinCE
Cc: hobu, warmerdam



I wanted to testbuild 1.5b2 on wince and encountered unresolved symbol linker errors due to
a new dependency of the core ogrgeometry.cpp class on KML / GeoJson? drivers for the exportToKML/Json methods.

Personally I would like to see export/import/conversion methods not in the ogrgeometry class
but in an own class with an own header file. But thats maybe something for an 1.6 release. Until then the methods in the ogrgeometry should be guarded by the appropriate ifdefs.

Attachments (1)

ogrgeometry.patch (1.6 KB) - added by wbaer 13 years ago.
ifdefs KML/GeoJSON export methods

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by wbaer

Attachment: ogrgeometry.patch added

ifdefs KML/GeoJSON export methods

comment:1 Changed 13 years ago by warmerdam

Cc: hobu added
Component: OGR_SFConfigBuild
Priority: highnormal
Status: newassigned

A related error occurs if you build --without-ogr on linux.

/wrk/home/warmerda/wrk/gdal-1.5.0b2/.libs/ undefined reference to `AVCBinReadOpen'
/wrk/home/warmerda/wrk/gdal-1.5.0b2/.libs/ undefined reference to `AVCBinReadClose'
/wrk/home/warmerda/wrk/gdal-1.5.0b2/.libs/ undefined reference to `OGR_G_ExportToJson'
/wrk/home/warmerda/wrk/gdal-1.5.0b2/.libs/ undefined reference to `OGR_G_ExportToKML'
/wrk/home/warmerda/wrk/gdal-1.5.0b2/.libs/ undefined reference to `AVCBinReadNextTableRec'

comment:2 Changed 13 years ago by warmerdam

Severity: criticalnormal

comment:3 Changed 13 years ago by warmerdam

Cc: warmerdam added
Component: ConfigBuildWinCE Port
Owner: changed from warmerdam to Mateusz Łoskot
Status: assignednew

I've skimmed the proposed patch, but I don't understand where the GEOJSON_ENABLED and KML_ENABLED macros are supposed to come from. In any event, the method must not be removed from the OGRGeometry API even if they are not implemented ... they should just issue a CPLError().

I have made some changes in ogrgeometry.cpp and aigdataset.cpp that fix the case where no OGR drivers are built and OGR_ENABLED is FALSE (r13334 in trunk), but this does not fix the problem on WinCE where it is common to build without most drivers. I'm turning this into a WinCE ticket, and turning over to mloskot to address as he sees fit (as long as it doesn't impact other platforms).

comment:4 Changed 11 years ago by warmerdam

Keywords: WinCE added
Milestone: 1.5.4
Owner: changed from Mateusz Łoskot to warmerdam
Priority: normallow

The WinCE port is currently orphaned for lack of developers.

comment:5 Changed 6 years ago by Jukka Rahkonen

Resolution: wontfix
Status: newclosed

Unrealistic to believe that bugs in Windows CE port will be fixed.

Note: See TracTickets for help on using tickets.