Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#1956 closed defect (fixed)

[PATCH] Shapefile DataSource open file counts

Reported by: warmerdam Owned by: warmerdam
Priority: low Milestone: 1.5.0
Component: OGR_SF Version: unspecified
Severity: normal Keywords: shapefile open files
Cc:

Description

Folks working with a lot of shapefiles often run into the "open file limit". It would be helpful if the OGR shapefile driver (and Shapelib) only kept the .shx file open long enough to read the contents - at least in readonly mode.

Attachments (1)

gdal_svn_trunk_close_shx_read_only_ticket_1956.patch​ (2.6 KB ) - added by Even Rouault 16 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by Even Rouault, 16 years ago

Milestone: → 1.5.0
Summary: Shapefile DataSource open file counts → [PATCH] Shapefile DataSource open file counts

The attached patch closes the SHX file at the end of SHPOpen() if pszAccess == 'rb'.

by Even Rouault, 16 years ago

Attachment: gdal_svn_trunk_close_shx_read_only_ticket_1956.patch​ added

comment:2 by warmerdam, 16 years ago

Resolution: → fixed
Status: new → closed

Patch applied upstream in shapelib, and ported into GDAL trunk (r12928).

Thanks!

comment:3 by warmerdam, 16 years ago

Umm, correction - it was actually r12930.

comment:4 by warmerdam, 16 years ago

Another fix for fpSHX being NULL in ogrshapelayer.cpp (r13355).

Note: See TracTickets for help on using tickets.