[PATCH] Fixes compilation with -Wall -Werror

[Even Rouault]

Most fixes are to suppress "warning: dereferencing type-punned pointer will break strict-aliasing rules", which is not always easy to do in an elegant way. One big change (in term of diff) is for frmts/aigrid/aigccitt.c where 3 arrays of structure elements missed a lot of braces.

Apart from cosmetic and boring changes, I think that I've catched a bug in the process. See :

Index: frmts/fit/fitdataset.cpp
===================================================================
--- frmts/fit/fitdataset.cpp    (révision 11867)
+++ frmts/fit/fitdataset.cpp    (copie de travail)
@@ -941,7 +941,7 @@
         CPLDebug("FIT", "Loading file with header version 01");

         // map old style header into new header structure
-       FIThead01* head01 = (FIThead01*)&head;
+       FIThead01* head01 = (FIThead01*)head;
         gst_swapb(head->dataOffset);
        info->dataOffset = head01->dataOffset;

[warmerdam]

Even, please go ahead and apply.

Thanks

[Even Rouault]

Commited in trunk in r11896

[warmerdam]

Doh! I thought the patch only included the fitdataset.cpp change.

The changes in the various support libraries (eg. libtiff, libgeotiff, avc*) are not appropriate and should be backed out.

[Even Rouault]

Sorry for the misunderstanding. I'm going to revert.

[Even Rouault]

In r11897, revert all unintended changes made in r11896. Just keep the fitdataset.cpp change.

[warmerdam]

I have applied the aigccitt.c patch as well (r11903).

[warmerdam]

It's too late to try and fix type punning warnings in 1.5.

[hobu]

Kicking this forward. If it is now just a bug for holding type punned warning fixes, maybe it should be closed and a new one created?

[Even Rouault]

Untargetting

[Even Rouault]

Probably completely out dated but cc'ing Kurt in case he wants to extract stuff from that

[Jukka Rahkonen]

Must be completely outdated now 7 years later and Kurt have had enough time to consider what to do.