Opened 17 years ago

Closed 13 years ago

#1629 closed task (wontfix)

Replace all occurrences of std::string with CPLString

Reported by: Mateusz Łoskot Owned by: warmerdam
Priority: low Milestone:
Component: default Version: unspecified
Severity: minor Keywords: CPLString std::string


In some files, there is still std::string class used directly instead of CPLString wrapper. This task suggests to review and replace std::string with CPLString.

Change History (1)

comment:1 by Mateusz Łoskot, 13 years ago

Resolution: wontfix
Status: newclosed

I'm closing my own ticket re-reviewing it. In my opinion, it should be changed the other way around, replace all CPLString with std::string. The CPLString is generally a bad idea declaring conversion operator char* forbidden in std::string by design. The printf-like functions are a potential security backdoors allocating big chunks on stack and driving additional allocations by return value from vsnprintf which fails due to formatting failures, not only buffer sizes).

Note: See TracTickets for help on using tickets.