Opened 17 years ago

Last modified 17 years ago

#1514 closed defect (fixed)

Query results not cleaned in Soft Transactions of PG — at Initial Version

Reported by: Mateusz Łoskot Owned by: Mateusz Łoskot
Priority: high Milestone:
Component: OGR_SF Version: 1.4.0
Severity: major Keywords:
Cc:

Description 

In functions operating on Soft Transactions, query results are not properly released when error occur.
Is it intentional?

For example, in OGRPGDataSource::SoftRollback()

---------------------------------------------------
hResult = PQexec(hPGConn, "ROLLBACK");

if( !hResult || PQresultStatus(hResult) != PGRES_COMMAND_OK )
   return OGRERR_FAILURE;

PQclear( hResult );
---------------------------------------------------

The PQclear() call is missing before return OGRERR_FAILURE.

Change History (0)

Note: See TracTickets for help on using tickets.