Opened 17 years ago
Closed 14 years ago
#1459 closed defect (fixed)
update interface to latest dwg/dxf lib
Reported by: | Owned by: | warmerdam | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | OGR_SF | Version: | svn-trunk |
Severity: | normal | Keywords: | dxf dwg |
Cc: | tcollett, gok@…, Mateusz Łoskot |
Description (last modified by )
Attachments (3)
Change History (13)
by , 17 years ago
comment:1 by , 17 years ago
Version: | 1.4.0 → svn-trunk |
---|
comment:2 by , 16 years ago
In order to support latest 2.05.01 DWG/DXF library (DDWG) from ODA. And I hope it will support all future DDWG versions.
Changes done in ogr_dwg.h header (attached):
- switch from OdChar * to OdString &
- change OdInt32 to OdInt64
- make MyServices available (drop ifdef notdef) and put this name in OdStaticRxObject<MyServices> svcs;
DDWG has its own file buffer classes OdFileBuf.h, OdFileBuf.cpp in ddwg25\Extensions\ExServices so my guess there is no reason to keep it in gdal trunk gdal-1.4.4\ogr\ogrsf_frmts\dxfdwg. Just move those files out of gdal scope and add the same from DDWG.
Building with msvc 8.0 extra DDWG lib linked list:
DD_vc8MD_PdfToolkit.lib DD_vc8MD_PdfExport.lib DD_VC8MD_RxRasterServices.lib Gs_WinOpenGL.lib Gs_WinGDI.lib DD_VC8MD_Br.lib DD_VC8MD_BrepRenderer.lib DD_VC8MD_AcisBuilder.lib DD_VC8MD_ModelerGeometry.lib DD_VC8MD_DbCommands.lib DD_VC8MD_Alloc.lib DD_VC8MD_SvgExport.lib DD_VC8MD_Gi.lib DD_VC8MD_Jpeg.lib DD_VC8MD_Db.lib DD_VC8MD_DbRoot.lib DD_VC8MD_Ge.lib DD_VC8MD_Gs.lib DD_VC8MD_Root.lib opengl32.lib DD_VC8MD_ZLib.lib DD_VC8MD_zip.lib DD_VC8MD_SpatialIndex.lib DD_VC8MD_BmpExport.lib DD_VC8MD_RxPlotStyleServices.lib DD_VC8MD_DynBlocks.lib DD_VC8MD_Ave.lib DD_VC8MD_RxRasterProcessor.lib DD_vc8MD_Dwf7Import.lib DD_vc8MD_Dwf7Export.lib WhipTk.lib W3Dtk.lib DwfToolkit.lib DD_VC8MD_ExFieldEvaluator.lib DD_vc8MD_PlotSettingsValidator.lib DwfCore.lib
follow-up: 6 comment:3 by , 16 years ago
Component: | OGR_SRS → OGR_SF |
---|---|
Description: | modified (diff) |
Keywords: | dxfdwg added |
Priority: | highest → normal |
Severity: | blocker → normal |
Status: | new → assigned |
Gok,
If you could test an implementation without the local OdFileBuf.cpp/h that would be very helpful. These were the only reason I had to move the dxfdwg driver out of mainstream GDAL.
comment:4 by , 16 years ago
Cc: | added |
---|
I have committed the changes in gdal_diff (r13546). Are there distinct changes in the ogr_dwg.zip attachment? Can you guys (gok / tcollett) confirm here that you understand these changes are being contributed under the MIT/X license and that you have the right/permission to provide them?
comment:5 by , 16 years ago
No problem with the MIT/X license. The changes were based on the DWG examples (as was the original plugin) so there should be no problems there.
comment:6 by , 16 years ago
If you could test an implementation without the local OdFileBuf.cpp/h that would be very helpful...
With those changes I did build gdal from trunk using nmake /NOLOGO /f makefile.vc default and using vc8 project as well. Attached is modified nmake.opt to support DWG/DXF.
I'm not familiar with GDAL structure so somebody should implement driver, datasource. Some suggestions are in attached ogrdwgdriver/datasource code (dxfdwg.zip)
comment:7 by , 16 years ago
Cc: | added |
---|
comment:9 by , 16 years ago
Cc: | added |
---|---|
Description: | modified (diff) |
Keywords: | dxf dwg added; dxfdwg removed |
comment:10 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Another DXF driver with read & write support has been added into OGR 1.7.0
Have attached a patch to update DWG support to use DWG Direct library 2.04.01