Opened 13 years ago

Closed 12 years ago

#1173 closed defect (fixed)

[PATCH] gdal_translate: tiff tags discarded with -co profile=Geotiff or Baseline

Reported by: quickstuff@… Owned by: warmerdam
Priority: normal Milestone: 1.6.0
Component: GDAL_Raster Version: unspecified
Severity: minor Keywords: GeoTIFF
Cc: Mateusz Łoskot, Even Rouault

Description (last modified by Mateusz Łoskot)

While converting tiff to tiff with gdal_translate, the creation options PROFILE=GeoTIFF and PROFILE=BASELINE discard many existing tifftags and/or prevent the addition of new ones.

It seems to affect baseline (informative, non-critical tags such as Resolutionunit, Imagedescription etc.

Other baseline tags are unsupported whatever profile is invoked ; e.g. Artist or Copyright

Attachments (1)

gdal_svn_geotiff_fix_1527_and_1173.patch (5.2 KB) - added by Even Rouault 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by quickstuff@…

Guess it is related to the lines :
    if( EQUAL(pszProfile,"GDALGeoTIFF") )
        GTiffDataset::WriteMetadata( poSrcDS, hTIFF, FALSE );
in geotiff.cpp

comment:2 Changed 12 years ago by warmerdam

Cc: warmerdam added
Description: modified (diff)
Milestone: 1.5.0
Owner: changed from warmerdam to Mateusz Łoskot

Mateusz,

I'd appreciate your looking into this. I think we need to call WriteMetadata?() regardless of profile, but within WriteMetadata?() we need to avoid writing custom TIFF metadata tags unless we are in the default GDALGeoTIFF profile.

Lets just do this in trunk since changes are fairly high risk, and need is modest. There should be a test suite test of some sort added to check profile operation in this regard, and perhaps some others.

comment:3 Changed 12 years ago by Even Rouault

This is closely related to #1527.

I'm attaching a patch that should fix both issues.

Changed 12 years ago by Even Rouault

comment:4 Changed 12 years ago by Even Rouault

Summary: gdal_translate: tiff tags discarded with -co profile=Geotiff or Baseline[PATCH] gdal_translate: tiff tags discarded with -co profile=Geotiff or Baseline

comment:5 Changed 12 years ago by Mateusz Łoskot

Description: modified (diff)
Keywords: GeoTIFF added

comment:6 Changed 12 years ago by Mateusz Łoskot

Cc: Mateusz Łoskot added
Owner: changed from Mateusz Łoskot to Even Rouault

comment:7 Changed 12 years ago by warmerdam

Cc: Even Rouault added; warmerdam removed
Owner: changed from Even Rouault to warmerdam

I'll review the patch. I'm a bit nervous about this area.

comment:8 Changed 12 years ago by warmerdam

Milestone: 1.5.01.6.0

comment:9 Changed 12 years ago by warmerdam

Resolution: fixed
Status: newclosed

See #1527 for details, fixed in trunk (r14033) with tests (r14032).

Note: See TracTickets for help on using tickets.