Changes between Initial Version and Version 2 of Ticket #1017

Timestamp:

Jan 26, 2009, 9:04:04 AM (15 years ago)

Author:

warmerdam

Comment:

Chaitanya,

Could you please revise the patch to work properly against trunk, and to do some more careful evaluation of the FID values. In particular I would like:

• The FID values to be more completely scanned to ensure they are strictly a string of numeric digits, potentially prefixed by "F", and with no other characters, spaces, etc.
• Each time an FID value is extracted, iNextGMLId should be set to the maximum of the existing iNextGMLId value, and the FID value plus 1 - the objective here is to keep track of the next safe FID we could assign if we need to switch to serial fid assignment, without risk of conflicting with any existing FIDs.
• Keep a flag indicating whether we have encountered any illegal FIDs, in which case we will assign the FIDs serially even if the current FID seems legitimate.

If/when you are satisfied with these changes, please then extent autotest/ogr/ogr_gml_read.py to test these new capabilities and special cases, including introducing new (small) test files as needed.