Changes between Version 13 and Version 14 of FDORfc10

Timestamp:

Oct 24, 2007, 2:44:46 PM (17 years ago)

Author:

gregboone

Comment:

--

FDORfc10

@@ -10 +10 @@
 ||RFC Template Version||(1.0)|| 
 ||Submission Date||||
-||Last Modified||Klain Qin [[Timestamp]]||
+||Last Modified||Greg Boone [[Timestamp]]||
 ||Author||Klain Qin||
 ||RFC Status||Draft||
@@ -17 +17 @@
 ||Assigned PSC guide(s)||Greg Boone||
 ||'''Voting History'''|| ||
-||+1||Haris,Greg,Orest,Mateusz,Bob,Jason,Frank||
+||+1||||
 ||+0||||
 ||-0||||
@@ -50 +50 @@
 WMS Override API will accept a string instead of the enumeration for image format. It will only accept server defined format strings that contain ‘png’, ‘tiff’, ‘jpeg’ or ‘gif’ in their definitions. 
 
-For example, by calling {{{SetImageFormat("image/png; PhotometricInterpretation=PaletteColor")}}}, WMS Provider will return raster stream in palette model. And by calling {{{SetImageFormat("image/png; PhotometricInterpretation=RGB")}}}, the raster stream will be returned in RGB model. 
-
-In this way, WMS Provider could fully make use of the server capability to support different bit-depth. These additional parameters will go into the configuration file like:
-{{{
-<RasterDefinition name="Image">
-  <Format>image/png;PhotometricInterpretation=PaletteColor</Format> 
+For example, by calling 
+
+{{{
+SetImageFormat("image/png; PhotometricInterpretation=PaletteColor")
+}}}
+
+The WMS Provider will return raster stream in palette model. And by calling 
+
+{{{
+SetImageFormat("image/png; PhotometricInterpretation=RGB")
+}}}
+
+the raster stream will be returned in RGB model. 
+
+In this way, WMS Provider could fully make use of the server capability to support different bit-depth. These additional parameters will go into the configuration file in a NEW WMS configuration element <!FormatType>:
+
+{{{
+<RasterDefinition name="Image">
+  <FormatType>image/png;PhotometricInterpretation=PaletteColor</FormatType> 
   ...
 </RasterDefinition>
 }}}
+
 However, still only four image file formats are supported: png, tiff, jpeg, and gif. If the user passed a string that contains other image formats like "bmp", "wbmp", etc, an exception will be thrown. 
 
@@ -132 +146 @@
 
 
-== Implications ==
-
-•   The change is backwards compatible with existing config files. Existing config files will be readable by the updated WMS provider.
-
-•   The change is not forwards compatible. New config files created by the updated provider are not readable by earlier versions of the WMS provider.
-
-This is a problem because earlier versions of the WMS override API will do a strict check on parsing <Image> ... </Image> in the configuration file. It could only recognize "png", "jpg", "Gif", or "tif", as they are hard-coded in the code: 
-{{{
-    static FdoString* g_WmsImageFormatPng                   = L"PNG";
-    static FdoString* g_WmsImageFormatTif                   = L"TIF";
-    static FdoString* g_WmsImageFormatJpg                   = L"JPG";
-    static FdoString* g_WmsImageFormatGif                   = L"GIF";
-}}} 
+In order to make the proposed change both backwards and forwards compatible. Configuration files created by the 3.3.0 version of the WMS Provider will continue to write the value of the <Format> element as was previously done in FDO 3.2.2. This would allow continued compatibility with applications written for 3.2.2. At the same time the FDO 3.3 WMS provider configuration file would be modified to contain a new <!FormatType> element that would only be evaluated by the 3.3 version of the WMS provider and subsequent releases. FDO 3.3 would look for <!FormatType> first and if not found evaluate <Format>. FDO 3.2.2 would continue to evaluate <Format>  and ignore <!FormatType>. There would some duplication of information, but applications written on both versions of the WMS Provider should continue to work as designed. The <Format> would be deemed deprecated and removed once forward compatibility support is no longer required.
+
+The resulting 3.3 WMS configuration xml document would take the form of...
+
+{{{
+<RasterDefinition name="Image">
+  <Format>PNG</Format> // Deprecated element. This one is consistent with FDO 3.2.2
+  <FormatType>image/png;PhotometricInterpretation=PaletteColor</FormatType>
+...
+</RasterDefinition>
+}}}
+
+
+'''For the 3.2.2 FDO WMS configuration API'''....
+
+Calls to 
+
+{{{
+void FdoWmsOvRasterDefinition::SetFormatType(FdoWmsOvFormatType value);
+}}}
+
+would continue to result in the generation of XML content that contained only the FORMAT element as follows 
+
+{{{
+<RasterDefinition name="Image">
+  <Format>PNG</Format>
+  ...
+</RasterDefinition>
+}}}
+
+
+Calls to 
+
+{{{
+FdoWmsOvFormatType FdoWmsOvRasterDefinition::GetFormatType(void) const;
+}}}
+
+would continue to result in the return of the expected !FdoWmsOvFormatType enumeration type 
+
+
+'''For the 3.3 FDO WMS configuration API'''....
+
+Calls to 
+
+{{{
+void SetImageFormat(FdoString* value);
+}}}
+
+would result in the generation of XML content that contained both <Format> and <!FormatType>
+
+{{{
+<RasterDefinition name="Image">
+  <Format>PNG</Format>
+  <FormatType>image/png;PhotometricInterpretation=PaletteColor</Format>
+  ...
+</RasterDefinition>
+}}}
+
+where the content of <!FormatType> is the content passed through the call to !SetImageFormat() and the content of <Format> is interpreted and set form the allowed values of <!FormatType>, with a default value of PNG being used no valid interpretation can be made.
+
+Calls to 
+
+{{{
+FdoString* GetImageFormat(void) const;
+}}}
+
+would result in the return of the expected string set through the call to !SetImageFormat() and/or the value contained in the <!FormatType> element. The content in <Format> would not be returned or evaluated.
 
 == Test Plan ==
 
-Existing unit tests will be expanded to test those changes.
+Existing unit tests will be expanded to test those changes. Regression testing will be performed against applications using FDO 3.2.2.
 
 == Funding/Resources ==