Ticket #978 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

topological editing with snapping to segment yields 2 vertices instead of 1 adding vertex

Reported by: msieczka Owned by: timlinux
Priority: critical: causes crash or data corruption Milestone:
Component: Digitising Version: Trunk
Keywords: Cc: lami@…
Platform Version: Platform: All
Must Fix for Release: Yes Awaiting user input: no

Description

1. Add a line or polygon Shapefile or PostGIS layer.

2. In project properties enable topological editing, set snapping mode "to segment" or "to vertex and segment".

3. Digitize a line or boundary.

4. Add a vertex on it, move it - you see 2 vertices were added instead of 1. Topology broken.

SVN r8190.

Attachments

linie_utm33.zip Download (0.9 KB) - added by msieczka 5 years ago.
sample line shapefile
1_before.png Download (4.2 KB) - added by msieczka 5 years ago.
screendump 1
2_vertex_added.png Download (6.0 KB) - added by msieczka 5 years ago.
screendump 2
3_vertex_moved.png Download (6.0 KB) - added by msieczka 5 years ago.
screendump 3
4_vertex_moved2.png Download (6.1 KB) - added by msieczka 5 years ago.
screendump 4

Change History

Changed 5 years ago by leolami

  • cc lami@… added

Changed 5 years ago by msieczka

Still valid as of r8352.

Changed 5 years ago by timlinux

  • owner changed from nobody to timlinux
  • status changed from new to assigned
  • milestone changed from Version 1.0 to Version 0.11.0

Changed 5 years ago by timlinux

  • status changed from assigned to closed
  • resolution set to worksforme

Cant replicate. I created a new line using the 'lines' layer in tests/testdata. Digitised a line across one of the roads with a vertex snapped to the road I was crossing. When I subsequently move the vertex, 4 red guides appear and both features are modified in shape as I drag the vertex around.

I'm marking this as 'works for me'. Please advise with more detail if there is something I'm missing and we can adjust the status of the ticket accordingly.

Regards

Tim

Changed 5 years ago by msieczka

  • status changed from closed to reopened
  • resolution worksforme deleted

Tim

You need to set snapping different than 0 for the given layer to notice the bug.

The greater snapping threshold, the greater chance of reproducing the error - at 10 I have 100% "success" of adding 3 vertices instead of 1 in a line Shapefile layer.

Please please fix it before release.

Changed 5 years ago by timlinux

Hi

Ah ok - I had tested at 1 and at 0.1 and it was working ok - will retest.

Regards

Tim

Changed 5 years ago by timlinux

I still cant replicate this issue. Could you send me a small dataset to test with that will allow me to replicate?

If I cant replicate and resolve this tomorrow I am going to push this bug over to 1.0.0 milestone.

Regards

Tim

Changed 5 years ago by msieczka

Tim,

I can still reproduce the bug in latest trunk r8750. Follow this please:

1. Open the attached shapefile in QGIS.

2. Project properties: check "Enable topological editing".

3. Project properties > Snapping options: check the layer, Mode: "to vertex and segment", Tolerance: "10".

4. Toggle editing.

5. Add a vertex, move it - you'll see 3 vertices were added instead of 1. The attached screendumps show that it really happens.

Changed 5 years ago by msieczka

sample line shapefile

Changed 5 years ago by msieczka

screendump 1

Changed 5 years ago by msieczka

screendump 2

Changed 5 years ago by msieczka

screendump 3

Changed 5 years ago by msieczka

screendump 4

Changed 5 years ago by timlinux

Hi

Ah great thanks for that I can replicate the issue now.

Regards

Tim

Changed 5 years ago by mhugent

  • status changed from reopened to closed
  • resolution set to fixed

This should be fixed in r8753. Please test and reopen the bug if you still have the problem

Changed 4 years ago by anonymous

  • milestone Version 0.11.0 deleted

Milestone Version 0.11.0 deleted

Note: See TracTickets for help on using tickets.