Ticket #2891 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

WFS exceptions not handled by plugin

Reported by: strk Owned by: timlinux
Priority: major: does not work as expected Milestone: Version 1.6.0
Component: C++ Plugins Version: Trunk
Keywords: Cc:
Platform Version: Platform: All
Must Fix for Release: No Awaiting user input: no

Description

The WFS plugin doesn't seem to handle WFS exceptions thrown by ows server on getCapabilities request

Attachments

ExceptionText_on_GetCapabilities.patch Download (0.8 KB) - added by strk 3 years ago.
exception2.patch Download (1.7 KB) - added by strk 3 years ago.

Change History

Changed 3 years ago by strk

Changed 3 years ago by strk

The patch (apply from within src/plugins/wfs) handles presence of an ExceptionText? tag as a sign of an exception. It is probably too wide and fails when server doesn't send that. Didn't check standard document either. All I can tell is that this patch helps when trying to connect to the WFS server exposed by Drupal WFS server... (ie: handle with care)

Changed 3 years ago by mhugent

  • status changed from new to closed
  • resolution set to fixed

Applied in r13935. Thanks!

Changed 3 years ago by strk

  • status changed from closed to reopened
  • resolution fixed deleted

Wanted to make the check a bit smarter by only looking at the first tag rather than searching in the whole document. It should be faster when no exception is returned. Anyway, can send a new patch against trunk.

Changed 3 years ago by strk

Changed 3 years ago by strk

The new patch (exception2.patch) only inspects the first node in the returned XML to tell if it's an exception or not. This makes it faster in successful cases.

Also the patch gives more information (exceptionCode) and keeps the error window title to "Error" to give better visibility to other error messages (parsing error and connection error)

Changed 3 years ago by pcav

  • milestone set to Version 1.6.0

Changed 3 years ago by mhugent

  • status changed from reopened to closed
  • resolution set to fixed

Applied second patch in r13956. Thanks!

Note: See TracTickets for help on using tickets.