Opened 14 years ago

Closed 14 years ago

#2813 closed patch (fixed)

msvc compilation failure

Reported by: orgads Owned by: jef
Priority: critical: causes crash or data corruption Milestone: Version 1.5.0
Component: Build/Install Version: 1.4.0
Keywords: Cc:
Must Fix for Release: No Platform: Windows
Platform Version: Awaiting user input: no

Description

Hello,

When trying to compile on msvc, using flex and bison from msys, I'm receiving some error messages regarding the lexer. Some messages are about missing unistd.h, and one message is missing isatty(int) function.

I found the caused, and attached a patch for it. Please review and accept it.

Thanks,

  • Orgad

Attachments (1)

qgis-lexer.patch​ (468 bytes ) - added by orgads 14 years ago.
patch for src/core/qgssearchstringlexer.ll, that enables compiling on msvc

Download all attachments as: .zip

Change History (4)

by orgads, 14 years ago

Attachment: qgis-lexer.patch​ added

patch for src/core/qgssearchstringlexer.ll, that enables compiling on msvc

comment:1 by lutra, 14 years ago

Type: bug → patch

comment:2 by mhugent, 14 years ago

Owner: changed from nobody to jef

comment:3 by jef, 14 years ago

Resolution: → fixed
Status: new → closed

Thanks. Applied in r13740.

BTW GnuWin32's flex works without that patch on MSVC (and includes an unistd.h).

Note: See TracTickets for help on using tickets.