Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1745 closed patch (fixed)

QGis crashes dragging a Legend Layer File over a Legend Layer File Group

Reported by: gcarrillo Owned by: mhugent
Priority: critical: causes crash or data corruption Milestone: Version 1.2.0
Component: Map Legend Version: Trunk
Keywords: Drag Legend Layer File Group Cc: pcav
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

QGis crashes dragging a Legend Layer File over a Legend Layer File Group. It happen over center of the item Layer File Group because the Legend Layer File pass to the same level as symbology on the Legend Layer, below center of the Layer File Group the drag works fine. The drag is not allowed to another position.

Attachments (3)

patch_for_bug_1745.txt (1.4 KB ) - added by gcarrillo 15 years ago.
Patch for bug #1745
screenshot_bug_1745.png (56.9 KB ) - added by gcarrillo 15 years ago.
This is a screenshot for show the bad behavior in the legend.
legendpatch.diff (1.5 KB ) - added by mhugent 15 years ago.

Download all attachments as: .zip

Change History (14)

by gcarrillo, 15 years ago

Attachment: patch_for_bug_1745.txt added

Patch for bug #1745

comment:1 by mhugent, 15 years ago

Type: bugpatch

by gcarrillo, 15 years ago

Attachment: screenshot_bug_1745.png added

This is a screenshot for show the bad behavior in the legend.

comment:2 by lutra, 15 years ago

Cc: pcav added
Milestone: Version 1.2.0

Seems to me that this patch has not been applied yet.

Qgis 1.2 trunk under linux crashes (segfault) while qgis 1.2 under windows xp returns "access violation - no RTTI data!" but doesn't crash and remain usable.

comment:3 by lutra, 15 years ago

Owner: changed from gcarrillo to mhugent

comment:4 by mhugent, 15 years ago

Looking at the patch it seems to me that it would be better to handle it in a generic way in qgslegend.cpp (not only for LEGEND_LAYER_FILE and LEGEND_LAYER_FILE_GROUP). I'm nearly about to rush to the train station for holidays. I'm coming back to this ticket in about a week.

Regards, Marco

comment:5 by lutra, 15 years ago

maybe #1439 can be squeezed together with this one

by mhugent, 15 years ago

Attachment: legendpatch.diff added

comment:6 by mhugent, 15 years ago

Hi

I don't have the crash on my system, only the move of the legend layer file to the symbology section. 'legendpatch.diff' fixes that in a generic way (only using the return value of dest->accept(), without explicitely mention the concrete classes).

Could you test if this also works for you and if it fixes the crash on your system or not?

Thanks, Marco

comment:7 by lutra, 15 years ago

Hi,

It is pretty easy to reproduce the crash (rev. 11186), see this

http://www.faunalia.pt/downloads/qgis_legend_crash.mpeg

Now I'll compile the latest revision and try the patch.

comment:8 by lutra, 15 years ago

The pacth works for me (ubuntu 9.04, qgis rev. 11201).

comment:9 by mhugent, 15 years ago

Resolution: fixed
Status: newclosed

Ok, so I'm closing this ticket.

comment:10 by lutra, 15 years ago

but it wasn't yet committed, right?

comment:11 by mhugent, 15 years ago

Right, I was too quick with closing :-) Committed now in r11206.

Note: See TracTickets for help on using tickets.