Ticket #1234 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Suspicious retrival of active layer in dxf2shp converter

Reported by: mloskot Owned by: nobody
Priority: minor: annoyance Milestone:
Component: C++ Plugins Version: Trunk
Keywords: dxf2shp Cc:
Platform Version: 10.5 Platform: OS X
Must Fix for Release: No Awaiting user input: no

Description

In file dxf2shpconverter.cpp, lines 119-121, there are some actions implemented that seem to be garbage and never used:

QgsMapLayer *layer = mQGisIface->activeLayer();
if (layer)
    QgsVectorLayer *lyr = (QgsVectorLayer*)layer;

Or, it's a kind of logical error (cast and assignment to lyr object in local scope of if-condition) and the idea was to use the retrieved active layer but bits of usage are missing.

Change History

Changed 5 years ago by mloskot

Sorry, the link to file is broken, here is corrected version: dxf2shpconverter.cpp

Changed 5 years ago by jef

  • status changed from new to closed
  • resolution set to fixed

thanks. fixed in r9114

Note: See TracTickets for help on using tickets.