Ticket #41 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

LCC projection not thread safe

Reported by: artwisz Owned by: warmerdam
Priority: major Milestone: 4.7.0
Component: Core Version: unspecified
Keywords: lcc thread safe Cc:

Description

The lcc projection is currently not thread safe. The rho parameter should be removed from PJ and declared on the stack in the projection functions. File: PJ_lcc.c

Change History

Changed 6 years ago by warmerdam

  • type changed from enhancement to defect
  • component changed from default to Core

Unfortunately, I don't understand some of the entry points in PJ_lcc, and P->rho seems to be used in several of the functions. It is not at all clear it is a simple local that happens to have been put into the structure.

Also, this only puts full thread safety at risk - that is when multiple pj_fwd/pj_inv calls are being made on the same PJ object. With regard to thread safety I have traditionally been primarily concerned about safety when different threads are using distinct PJ objects which is not put at risk in this case.

I'm going to leave this open as a defect but I'm not expecting to take any immediate action.

Changed 6 years ago by artwisz

I have removed the rho from the PJ structure, made rho a local variable and both forward and inverse transforms seem to be working. If you take a look at all control paths in the code, rho is always calculated before being used, so it need not be a structure member. Moreover, the LCC ENTRY (init) does not initialize rho at all, only rho0. Generally, adding a const to the *pj parameter in the forward/inverse declarations is a good way to fish out all code where the structure is modified, which in this case is not thread safe. I am only using the LCC, so I don't know much about other projections.

Changed 5 years ago by warmerdam

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 4.7.0

I concur with your analysis. I have removed rho from the structure in trunk (r1629).

Note: See TracTickets for help on using tickets.