Ticket #97 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

Rename LWCURVE to LWCIRCSTRING

Reported by: mcayland Owned by: mcayland
Priority: medium Milestone: PostGIS 1.4.0
Component: postgis Version: 1.4
Keywords: Cc:

Description

See explanation here:

 http://postgis.refractions.net/pipermail/postgis-devel/2008-December/004421.html

The confusion stems from the fact that internally what we call a curve is actually a circularstring; hence when reading code it gets very confusing since in the SQL-MM spec, a curve is an abstract supertype and not a real type.

Change History

Changed 4 years ago by pramsey

Another issue with LWCURVE is that the changes are compartmentalized at the bottom of liblwgeom.h. This was fine when it was a work-in-progress, but if we're going to support curves, we need to integrate their support with the rest of the API, so that it is obvious when we're missing global support functions (lwcurve_free?).

If you're doing the re-naming house-keeping anyways, moving the struct defns with teh other structs, and casts with other casts, etc, etc, would be good.

Changed 4 years ago by mcayland

+1 from me - I found exactly the same thing when I was trying to find some of the CIRCULARSTRING crashes. Well, since I RFC'd this before Xmas and no was has commented, I'll go and ahead and make this happen (will probably take a few days as we have a show this week)...

ATB,

Mark.

Changed 4 years ago by mcayland

All done.

Please test to ensure that I didn't break too much :)

ATB,

Mark.

Changed 4 years ago by mcayland

Mark's had a play with this (and doesn't seem to have found anything too serious), so I'll mark this as fixed.

ATB,

Mark.

Note: See TracTickets for help on using tickets.