Ticket #556 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Return value of snprintf not correctly checked

Reported by: hopfgartner Owned by: pramsey
Priority: low Milestone:
Component: postgis Version: trunk
Keywords: Cc:

Description

In loader/shp2pgsql-core.c the return value of snprintf is compared to -1. Anyway, in case of errors the return value might >= the buffer size if the output string was truncated or -1 for other errors see man snprintf.

Attachments

shp2pgsql-core.c.diff Download (1.5 KB) - added by hopfgartner 3 years ago.

Change History

Changed 3 years ago by hopfgartner

Changed 2 years ago by pramsey

Committed to trunk at r6360, thanks for the patch!

Changed 2 years ago by pramsey

  • status changed from new to closed
  • resolution set to fixed

Committed to 1.5 at r6361.

Note: See TracTickets for help on using tickets.