Opened 14 years ago

Closed 14 years ago

#323 closed defect (fixed)

postgis_comments.sql missing from 1.4.1 rc1 and SVN tar balls

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 1.4.1
Component: postgis Version: 1.4.X
Keywords: Cc:

Description

It appears the comments are still missing in the 1.4 nightly and rc builds. though I see them in the postgis 1.5 svn one.

Change History (6)

comment:1 by pramsey, 14 years ago

The comments are a build target, why would they be included in the tar-ball, the users build them, no?

comment:2 by robe, 14 years ago

No. Its too much to ask for users to build them since it requires doc xsl stylesheets and so forth. Well really it doesn't but the way we have it it does.

Besides people shouldn't need xsltproc.

comment:3 by pramsey, 14 years ago

Shouldn't it be part of postgis.sql?

comment:4 by robe, 14 years ago

No. Because of that stupid GEOS thing we have wheree we allow people to install . It will fail if you have GEOS 3.1 if you wrap it in a transaction. I ahven't dealt with that issue because I think its LAME as I said. So comments always contains all functions even if you are running an older GEOS.

comment:5 by pramsey, 14 years ago

make_dist.sh updated to retain the comments sql file at r4928

comment:6 by pramsey, 14 years ago

Resolution: → fixed
Status: new → closed

rc2 release with comments.sql file in place.

Note: See TracTickets for help on using tickets.