Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#303 closed enhancement (fixed)

Test results are language dependent

Reported by: jorgearevalo Owned by: pramsey
Priority: low Milestone: PostGIS 1.5.0
Component: postgis Version: master
Keywords: tests Cc:

Description

When I execute make check after building postgis, some test appear as failed test because my enviroment is in spanish, and the expected results are always in english.

I'd find useful to warn user of this unclear fact before executing test suite.

Change History (8)

comment:1 by mloskot, 14 years ago

It should be easy to fix by temporarily resetting shell locale to C

comment:2 by pramsey, 14 years ago

Can you test this Jorge? Since you have easy access to a machine that already has a non-'C' locale :)

comment:3 by jorgearevalo, 14 years ago

Sure thing!

$ export LANG=C
$ make check
(…)
Run tests: 46
Failed: 0
$ export LANG=es_ES.UTF-8

I don't know if it's the best way, but it works for me. Maybe I should detect the previous value of LANG and then restore it.

in reply to:  3 comment:4 by jorgearevalo, 14 years ago

Replying to jorgearevalo:

Sure thing!

$ export LANG=C
$ make check
(…)
Run tests: 46
Failed: 0
$ export LANG=es_ES.UTF-8

I don't know if it's the best way, but it works for me. Maybe I should detect the previous value of LANG and then restore it.

Sorry, it's

LC_ALL=C

and

LC_ALL=es_ES.UTF-8

Instead of LANG.

comment:5 by pramsey, 14 years ago

I added in a 'C' setting in run_test, can you check that trunk at r4815 works?

comment:6 by pramsey, 14 years ago

Resolution: fixed
Status: newclosed

comment:7 by mloskot, 14 years ago

I confirm nothing has got broken for me, everything works here. Thanks Paul!

comment:8 by jorgearevalo, 14 years ago

Thanks Paul! I have the lang problem solved. Now I have a test failed. The wmsservers test. I don't know if it's related. This is the diff (really difficult to find the differences in lines preceded by !):

*** wmsservers_expected	Mon Nov 16 22:32:26 2009
--- /tmp/pgis_reg_4598/test_42_out	Mon Nov 16 23:30:45 2009
***************
*** 7,40 ****
  POLYGON
  4326
  -500|AAAAAAMAAAABAAAAIcAQAAAAAAAAAAAAAAAAAADAEBOtBgEUar/I+Lg8aaYEwBBN8oYZrle/2H3i
! pq6pXMAQrJM63ivLv+HHOzmuaMTAESvsMzAYhr/moJ5mfzvIwBHHGJjKMua/6ptmKQ6hnsASeCHV
  lRVpv+2Qa88yjULAEzg6Phyyzr/vYpfP91yuwBP///////6/8AAAAAAAAMAUx8XB400uv+9il8/3
! XLPAFYfeKmrqlL/tkGvPMo1NwBY452c1zRe/6ptmKQ6hrsAW1BPMz+d4v+agnmZ/O9zAF1NsxSHU
! M7/hxzs5rmjbwBeyDXnmUai/2H3ipq6pkcAX7FL5/uuVv8j4uDxppnTAGAAAAAAAALztGmJjMUXA
! wBfsUvn+65c/yPi4PGmlkcAXsg155lGqP9h94qauqSbAF1NsxSHUNz/hxzs5rmirwBbUE8zP530/
  5qCeZn87ssAWOOdnNc0dP+qbZikOoY3AFYfeKmrqmj/tkGvPMo04wBTHxcHjTTU/72KXz/dcqcAU
  AAAAAAAEP/AAAAAAAADAEzg6Phyy1D/vYpfP91y2wBJ4IdWVFW0/7ZBrzzKNUsARxxiYyjLqP+qb
! ZikOobLAESvsMzAYiT/moJ5mfzvfwBCskzreK80/4cc7Oa5o3MAQTfKGGa5YP9h94qauqYvAEBOt
  BgEUaj/I+Lg8aaZawBAAAAAAAAAAAAAAAAAAAA==
  1
! 25|AAAAAAMAAAABAAAAIT/wAAAAAAAAQDkAAAAAAAA/72KXz/dcsEA4zg6Phyy0P+2Qa88yjUhAOJ4I
! dWVFWz/qm2YpDqGmQDhxxiYyjLo/5qCeZn870kA4SvsMzAYiP+HHOzmuaNFAOCskzreK8z/YfeKm
! rql2QDgTfKGGa5Y/yPi4PGmmPEA4BOtBgEUbPN0aYmMxRcBAOAAAAAAAAL/I+Lg8aaXKQDgE60GA
! RRq/2H3ipq6pQEA4E3yhhmuWv+HHOzmuaLhAOCskzreK87/moJ5mfzu+QDhK+wzMBiG/6ptmKQ6h
  lkA4ccYmMoy5v+2Qa88yjT1AOJ4IdWVFWr/vYpfP91yrQDjODo+HLLO/8AAAAAAAAEA4////////
  v+9il8/3XLZAOTHxcHjTS7/tkGvPMo1TQDlh94qauqW/6ptmKQ6ht0A5jjnZzXNFv+agnmZ/O+dA
! ObUE8zP53r/hxzs5rmjqQDnU2zFIdQy/2H3ipq6pqEA57INeeZRqv8j4uDxpppdAOfsUvn+65bzw
! 08nKZPRQQDoAAAAAAAA/yPi4PGmljkA5+xS+f7rmP9h94qauqSxAOeyDXnmUaz/hxzs5rmixQDnU
  2zFIdQ4/5qCeZn87ukA5tQTzM/nfP+qbZikOoZZAOY452c1zRz/tkGvPMo0+QDlh94qauqY/72KX
  z/dcrEA5MfFweNNNP/AAAAAAAABAOQAAAAAAAA==
! 25|AAAAAAMAAAABAAAAIT/wAAAAAAAAQDkAAAAAAAA/72KXz/dcsEA4zg6Phyy0P+2Qa88yjUhAOJ4I
! dWVFWz/qm2YpDqGmQDhxxiYyjLo/5qCeZn870kA4SvsMzAYiP+HHOzmuaNFAOCskzreK8z/YfeKm
! rql2QDgTfKGGa5Y/yPi4PGmmPEA4BOtBgEUbPN0aYmMxRcBAOAAAAAAAAL/I+Lg8aaXKQDgE60GA
! RRq/2H3ipq6pQEA4E3yhhmuWv+HHOzmuaLhAOCskzreK87/moJ5mfzu+QDhK+wzMBiG/6ptmKQ6h
  lkA4ccYmMoy5v+2Qa88yjT1AOJ4IdWVFWr/vYpfP91yrQDjODo+HLLO/8AAAAAAAAEA4////////
  v+9il8/3XLZAOTHxcHjTS7/tkGvPMo1TQDlh94qauqW/6ptmKQ6ht0A5jjnZzXNFv+agnmZ/O+dA
! ObUE8zP53r/hxzs5rmjqQDnU2zFIdQy/2H3ipq6pqEA57INeeZRqv8j4uDxpppdAOfsUvn+65bzw
! 08nKZPRQQDoAAAAAAAA/yPi4PGmljkA5+xS+f7rmP9h94qauqSxAOeyDXnmUaz/hxzs5rmixQDnU
  2zFIdQ4/5qCeZn87ukA5tQTzM/nfP+qbZikOoZZAOY452c1zRz/tkGvPMo0+QDlh94qauqY/72KX
  z/dcrEA5MfFweNNNP/AAAAAAAABAOQAAAAAAAA==
  id
--- 7,40 ----
  POLYGON
  4326
  -500|AAAAAAMAAAABAAAAIcAQAAAAAAAAAAAAAAAAAADAEBOtBgEUar/I+Lg8aaYEwBBN8oYZrle/2H3i
! pq6pXMAQrJM63ivLv+HHOzmuaMTAESvsMzAYhr/moJ5mfzvHwBHHGJjKMua/6ptmKQ6hnsASeCHV
  lRVpv+2Qa88yjULAEzg6Phyyzr/vYpfP91yuwBP///////6/8AAAAAAAAMAUx8XB400uv+9il8/3
! XLPAFYfeKmrqlL/tkGvPMo1NwBY452c1zRe/6ptmKQ6hrcAW1BPMz+d4v+agnmZ/O9vAF1NsxSHU
! M7/hxzs5rmjbwBeyDXnmUai/2H3ipq6pkcAX7FL5/uuVv8j4uDxppnXAGAAAAAAAALztGmAAAAAA
! wBfsUvn+65c/yPi4PGmlkMAXsg155lGqP9h94qauqSXAF1NsxSHUNz/hxzs5rmirwBbUE8zP530/
  5qCeZn87ssAWOOdnNc0dP+qbZikOoY3AFYfeKmrqmj/tkGvPMo04wBTHxcHjTTU/72KXz/dcqcAU
  AAAAAAAEP/AAAAAAAADAEzg6Phyy1D/vYpfP91y2wBJ4IdWVFW0/7ZBrzzKNUsARxxiYyjLqP+qb
! ZikOobLAESvsMzAYiT/moJ5mfzvfwBCskzreK80/4cc7Oa5o3MAQTfKGGa5YP9h94qauqYzAEBOt
  BgEUaj/I+Lg8aaZawBAAAAAAAAAAAAAAAAAAAA==
  1
! 25|AAAAAAMAAAABAAAAIT/wAAAAAAAAQDkAAAAAAAA/72KXz/dcsUA4zg6Phyy0P+2Qa88yjUhAOJ4I
! dWVFWz/qm2YpDqGmQDhxxiYyjLo/5qCeZn870kA4SvsMzAYiP+HHOzmuaNBAOCskzreK8z/YfeKm
! rql2QDgTfKGGa5Y/yPi4PGmmPEA4BOtBgEUbPN0aYAAAAABAOAAAAAAAAL/I+Lg8aaXKQDgE60GA
! RRq/2H3ipq6pQEA4E3yhhmuWv+HHOzmuaLlAOCskzreK87/moJ5mfzu+QDhK+wzMBiG/6ptmKQ6h
  lkA4ccYmMoy5v+2Qa88yjT1AOJ4IdWVFWr/vYpfP91yrQDjODo+HLLO/8AAAAAAAAEA4////////
  v+9il8/3XLZAOTHxcHjTS7/tkGvPMo1TQDlh94qauqW/6ptmKQ6ht0A5jjnZzXNFv+agnmZ/O+dA
! ObUE8zP53r/hxzs5rmjpQDnU2zFIdQy/2H3ipq6pqEA57INeeZRqv8j4uDxpppZAOfsUvn+65bzw
! 08gAAAAAQDoAAAAAAAA/yPi4PGmljkA5+xS+f7rmP9h94qauqSxAOeyDXnmUaz/hxzs5rmixQDnU
  2zFIdQ4/5qCeZn87ukA5tQTzM/nfP+qbZikOoZZAOY452c1zRz/tkGvPMo0+QDlh94qauqY/72KX
  z/dcrEA5MfFweNNNP/AAAAAAAABAOQAAAAAAAA==
! 25|AAAAAAMAAAABAAAAIT/wAAAAAAAAQDkAAAAAAAA/72KXz/dcsUA4zg6Phyy0P+2Qa88yjUhAOJ4I
! dWVFWz/qm2YpDqGmQDhxxiYyjLo/5qCeZn870kA4SvsMzAYiP+HHOzmuaNBAOCskzreK8z/YfeKm
! rql2QDgTfKGGa5Y/yPi4PGmmPEA4BOtBgEUbPN0aYAAAAABAOAAAAAAAAL/I+Lg8aaXKQDgE60GA
! RRq/2H3ipq6pQEA4E3yhhmuWv+HHOzmuaLlAOCskzreK87/moJ5mfzu+QDhK+wzMBiG/6ptmKQ6h
  lkA4ccYmMoy5v+2Qa88yjT1AOJ4IdWVFWr/vYpfP91yrQDjODo+HLLO/8AAAAAAAAEA4////////
  v+9il8/3XLZAOTHxcHjTS7/tkGvPMo1TQDlh94qauqW/6ptmKQ6ht0A5jjnZzXNFv+agnmZ/O+dA
! ObUE8zP53r/hxzs5rmjpQDnU2zFIdQy/2H3ipq6pqEA57INeeZRqv8j4uDxpppZAOfsUvn+65bzw
! 08gAAAAAQDoAAAAAAAA/yPi4PGmljkA5+xS+f7rmP9h94qauqSxAOeyDXnmUaz/hxzs5rmixQDnU
  2zFIdQ4/5qCeZn87ukA5tQTzM/nfP+qbZikOoZZAOY452c1zRz/tkGvPMo0+QDlh94qauqY/72KX
  z/dcrEA5MfFweNNNP/AAAAAAAABAOQAAAAAAAA==
  id

Note: See TracTickets for help on using tickets.