ST_SetValues doc should specify 1-indexing for column/row parameters

[strk]

Reading the examples for ST_SetValues it looks like the columnx and rowy parameters are 1-indexed, but it is not written in the documentation. Would better be.

[sunveersingh]

Hello, I would like to work on this issue, please let me know how can I help.

[strk]

You can verify what the ticket description says (that argument refers to first element with 1 instead of 0), then provide a patch for the documentation. Note you can also provide coordinates for pulling your changes from a git repository, possibly by using a fork of one of PostGIS' CodeMirrors.

[komzpa]

sunveersingh, it is much like the previous issue you fixed! let's start a bit earlier in the process this time:

1. go ​https://github.com/postgis/postgis/tree/svn-trunk/doc
2. find file that mentions ST_SetValues inside
3. edit it, so it is clear from text that row and column are 1-indexed
4. provide a pull request with change.

[sunveersingh]

I found the file: ​https://github.com/postgis/postgis/blob/svn-trunk/doc/reference_raster.xml#L5317 is it correct?

[komzpa]

sunveersingh, I'll check after you do (4)

[sunveersingh]

Here we go: ​https://github.com/postgis/postgis/pull/328

[komzpa]

In 17000:

Specified 1-indexing in ST_SetValues

Patch by Sunveer Singh

Closes ​https://github.com/postgis/postgis/pull/328
Closes #2835