Compile problem on non-GNU systems (__va_copy)

[pramsey]

gcc -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes shpopen.o dbfopen.o getopt.o shp2pgsql.o ../liblwgeom/liblwgeom.a  -lm -o shp2pgsql
../liblwgeom/liblwgeom.a(vsprintf.o)(.text+0x1c): In function `lw_vasprintf':
/usr/src/smit/postgis-1.4.0rc1/liblwgeom/vsprintf.c:150: undefined reference to `__va_copy'
gmake[1]: *** [shp2pgsql] Error 1
gmake[1]: Leaving directory `/usr/src/smit/postgis-1.4.0rc1/loader'
gmake: *** [loaderdumper] Error 2
gmake -C liblwgeom

[pramsey]

Interim patch from mcayland

[pramsey]

OS/X does not complain about this patch.

[pramsey]

OpenSolaris does not complain about this patch.

[mcayland]

Okay great. I seem to remember something in the back of my mind about some of the va_args stuff being different between 32-bit/64-bit platforms? Can someone check on a 32-bit system and make sure that print output is not garbled? (building —with-debug and running a few simple queries would be a good test, as I seem to remember that just building was not a good enough test to make sure it actually worked).

ATB,

Mark.

[robe]

Tried under 32-bit and compiled fine. Did a couple of queries as well and compared my results to pre-version results and seemed to come out the same.

tested new loader changes and seemed to work fine too.

[robe]

Forgot to mention my 32-bit tests were with binaries I compiled with mingW.

[robe]

Oops forgot Mark hasn't committed this yet so can't close out until he commits to SVN. Mark can you commit and close out.

[mcayland]

Sorry - was out in meetings all day yesterday.

Applied to 1.4 branch and trunk as r4263 and r4264 respectively.

ATB,

Mark.