Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1974 closed defect (fixed)

Imagemagick generate.c produces crappy images under windows

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 2.1.0
Component: postgis Version: trunk
Keywords: Cc:

Description

I'm not sure if this is just a windows issue or if it is because I am using a newer imagemagick. I'm using the latest binaries for windows from here: http://www.imagemagick.org/script/binary-releases.php#windows

ImageMagick?-6.7.9-3-Q16-windows.zip

Anyrate there are 2 issues which I've found work-arounds for and hopefully these changes won't screw everyone else on other OS

1) calls like

convert tmp%d.png \\( +clone -channel A -separate +channel -negate -background black -virtual-pixel background -blur 0x3 -shade 120x55 -contrast-stretch 0%% +sigmoidal-contrast 7x50%% -fill grey50 -colorize 10%% +clone +swap -compose overlay -composite \\) -compose In -composite tmp%d.png

I have to change to

convert tmp%d.png ( +clone -channel A -separate +channel -negate -background black -virtual-pixel background -blur 0x3 -shade 120x55 -contrast-stretch 0%% +sigmoidal-contrast 7x50%% -fill grey50 -colorize 10%% +clone +swap -compose overlay -composite ) -compose In -composite tmp%d.png

Because with the
it complains about

 no decode delegate for this image format `\('

and creates blurry blue images

It also doesn't like RGB and Alpha colors definitions in styles.conf, so I've had to hack my style.conf to use named colors. It gives errors like:

convert.exe: unable to open image `'#00ff0080'': No such file or directory @ err
or/blob.c/OpenBlob/2641.

I'm going to work on that a bit more to see if I can still keep RGB/RGBA or at least map it to same colors as before or come up with REALLY bizarre colors.

Unfortunately don't have Hudson around to complain when I screw Linux users. Hopefully will have a Debian replacement soon, but I want to get Winnie able to build everything except possibly the PDF before I explore unknown Debian waters.

Change History (7)

comment:1 Changed 7 years ago by robe

Owner: changed from pramsey to robe

comment:2 Changed 7 years ago by robe

Resolution: fixed
Status: newclosed

Fixed at r10222 . Please everyone test to make sure it still works for you since I'm just pretending to know what I'm doing.

comment:3 Changed 7 years ago by strk

Resolution: fixed
Status: closedreopened

Parens have a special meaning on the shell so they must be quoted. I used single-quote escaping with r10223 -- still need to re-add quotes to the styles in order for things to work here. What was the error message without those quotes ?

comment:4 Changed 7 years ago by strk

ok we finally figured. Windows wants to escape with double quotes. So both in the escaping of parens and in the escaping of styles.

Robe should be committing the change shortly

comment:5 Changed 7 years ago by robe

Resolution: fixed
Status: reopenedclosed

committed at r10224-r10226

comment:6 Changed 7 years ago by robe

make that r10225, r10226

comment:7 Changed 7 years ago by strk

now let's hope Apples don't insist on a yet different quoting mechanism...

Note: See TracTickets for help on using tickets.