postgres.h header isnot included first

[mloskot]

Note that you should always include postgres.h first in any source file, because it declares a number of things that you will need anyway.

[mloskot]

I'm sorry, but apparently I've had no idea that Google Code magically reacts on some keystrokes, so I accidentally submitted incomplete report.

The problem is that PostGIS sources does NOT include postgres.h header first, on top of other source files, as chapter 34.9.2. 'Base Types in C-Language Function' of PostgreSQL manual specifies:

Note that you should always include postgres.h first in any source file, because it declares a number of things that you will need anyway.

This causes number of problems while building PostGIS using Microsoft Visual C++ (8.0) compiler.

I attached patch I generated against recent svn trunk revision and tested on Linux.

[mcayland]

This looks fine to me, and compiles without any issues here. Applied to SVN trunk.

ATB,

Mark.

[mloskot]

​http://postgis.googlecode.com/issues/attachment?aid=-5930245774481019099&name=postgis-r3820-postgres_h-goes-first.patch

[mloskot]

Mark,

Thanks for patching this. I confirm it works for me as well.