postgis_type_name() misses some type/dim combinations

[strk]

select topology.createtopology('ttz', 4326, 0, true);


ERROR:  Invalid type name - valid ones are:
        POINT, MULTIPOINT,
        LINESTRING, MULTILINESTRING,
        POLYGON, MULTIPOLYGON,
        CIRCULARSTRING, COMPOUNDCURVE, MULTICURVE,
        CURVEPOLYGON, MULTISURFACE,
        GEOMETRY, GEOMETRYCOLLECTION,
        POINTM, MULTIPOINTM,
        LINESTRINGM, MULTILINESTRINGM,
        POLYGONM, MULTIPOLYGONM,
        CIRCULARSTRINGM, COMPOUNDCURVEM, MULTICURVEM
        CURVEPOLYGONM, MULTISURFACEM, TRIANGLE, TRIANGLEM,
        POLYHEDRALSURFACE, POLYHEDRALSURFACEM, TIN, TINM
        or GEOMETRYCOLLECTIONM
CONTEXT:  SQL statement "SELECT AddGeometryColumn('', $1 , $2 , $3 , $4 , $5 , $6 , $7 )"
PL/pgSQL function "addgeometrycolumn" line 4 at SQL statement
SQL statement "SELECT AddGeometryColumn('ttz','edge_data','geom','4326','LINESTRING',3)"

[strk]

This is actually unrelated to topology, it's the AddGeometryColumn? function itself erroring out on 'LINESTRING'. It doesn't even need any existing schema or table ...

=# SELECT AddGeometryColumn('ttz','edge_data','geom','4326','LINESTRING',3);
ERROR:  Invalid type name - valid ones are:
        POINT, MULTIPOINT,
        LINESTRING, MULTILINESTRING,
        POLYGON, MULTIPOLYGON,
        CIRCULARSTRING, COMPOUNDCURVE, MULTICURVE,
        CURVEPOLYGON, MULTISURFACE,
        GEOMETRY, GEOMETRYCOLLECTION,
        POINTM, MULTIPOINTM,
        LINESTRINGM, MULTILINESTRINGM,
        POLYGONM, MULTIPOLYGONM,
        CIRCULARSTRINGM, COMPOUNDCURVEM, MULTICURVEM
        CURVEPOLYGONM, MULTISURFACEM, TRIANGLE, TRIANGLEM,
        POLYHEDRALSURFACE, POLYHEDRALSURFACEM, TIN, TINM
        or GEOMETRYCOLLECTIONM

[strk]

For the record this is as of r7550

[strk]

Following the code flow this turns out being a problem with postgis_type_name('LINSTRING', 3).

Regress tests !!

[robe]

Fixed at r7553.

Sorry haven't had a chance to test topology and raster since the change since its more difficult with those broken curves :)

[robe]

fixed multilinestringZ, geometry z zm cases at r7559 added extra line between families for easier detection.

[strk]

Robe: could you please add a cohomprensive testcase containing all known permutations ? You've still left bogus entries in there... I wont' tell which one or you'd keep fixing just the ones I mention :P

[strk]

I'm working on regress test and fixes

[strk]

This is closes and regress-tested as of r7576