Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#452 closed defect (fixed)

tilelite prompts user when run a 2nd time

Reported by: camerons Owned by: springmeyer
Priority: minor Milestone:
Component: OSGeoLive Keywords: tilelite
Cc: live-demo@…

Description

If the /tmp/ directory has already been populated (as happens when you run a script for the second time), the tilelite script will ask for the user to confirm to replace files or not.

This shouldn't happen as we wish to make the install process as automated as possible.

Change history (8)

comment:1 Changed 10 years ago by wildintellect

Seems we should have a general policy and possibly a flag. IE: by default overwrite, by flag option use existing. That way if someone is running it a second time they can save time by using the already existing tmp files.

comment:2 in reply to:  description Changed 10 years ago by hamish

Replying to camerons:

If the /tmp/ directory has already been populated (as happens when you run a script for the second time), the tilelite script will ask for the user to confirm to replace files or not.

This shouldn't happen as we wish to make the install process as automated as possible.

is this from setdown.sh or install_mapnik.sh?

if it's setdown.sh just make the mv to \mv which is the raw non-interactive version. or add the -f flag to it.

often folks alias mv='mv -i' to stop themselves making silly mistakes, but when run from a script the .alias file typically isn't sourced so you only see it when cutting and pasting bits of the script into the terminal.

Hamish

comment:3 Changed 10 years ago by springmeyer

Owner: changed from live-demo@… to springmeyer
Status: newassigned

Thanks for catching this Cameron.

The problem was during unzipping the source files of TileLite? with 'unzip' and is easily fixed by passing the -o (for overwrite) flag to the 'unzip' command.

Fix in r2275 (accidentally under the username camerons since I (springmeyer) committed from the running live-demo disc '~gisvm/trunk/' svn checkout.

comment:4 Changed 10 years ago by springmeyer

Resolution: fixed
Status: assignedclosed

comment:5 Changed 10 years ago by hamish

Keywords: tilelite added

fyi r2267 had already fixed this; sorry, I didn't notify the bug tracker.

that checkin has now been clobbered by r2275 (everyone does svn up and svn diff before svn commit, right?); please see the gisvm build rules on the live-demo wiki page about using /tmp/build_<package name> and keeping .zip files around to make running scripts twice faster.

also please try to keep install scripts self-contained, ie don't have install_mapnik adjusting the install_tilelite stuff and vice versa. If they belong in the same script, so be it. if one should be sourced from the other, move the daughter script down out of the bin dir (see others).

thanks, Hamish

comment:6 Changed 10 years ago by springmeyer

not sure how that clobbering happened, sorry about that. I certainly did svn up and normally I would think svn would tell me the file was out of date if I forgot.

Okay, I also re-read the rules. In this case the download is under a MB so hopefully it is fine as is to drop the zip download? The reason I preferred this is to allow updates that I make in the TileLite? sources to be automatically reflected in the liveDVD install since I've had to tweak things a bit to get TileLite? to run with the old version of Mapnik provided by Xubuntu packages (and I may still need to make a few more).

thanks,

dane

comment:7 Changed 10 years ago by hamish

no worries, as long as it works.

comment:8 Changed 7 years ago by hamish

Cc: live-demo@… added

please move the ML email addr from the owner field if you take ownership of a ticket so it doesn't get lost

Note: See TracTickets for help on using tickets.